Issue 907: Make 5.1/atomic/test_atomic_fail_*.{c,F90} less racy#910
Open
tob2 wants to merge 1 commit into
Open
Issue 907: Make 5.1/atomic/test_atomic_fail_*.{c,F90} less racy#910tob2 wants to merge 1 commit into
tob2 wants to merge 1 commit into
Conversation
The current code sets 'y = 1' and then atomically 'x = 10' in the first thread,
expecting that once 'y' shows up as updated in the second thread, 'x' is also
updated. - But this is racy.
With this commit, 'y' is set non atomically after the atomic write.
This applies to all 6 tests:
tests/5.1/atomic/test_atomic_fail_{acquire,relexed,seq_cst}.{c,F90}.
tob2
changed the title
Collaborator
Author
|
@spophale @fel-cab @seyonglee – Please review. (Cross-ref: last change to those files was done in Pull Req. #776) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #907
The current code sets
y = 1and then atomicallyx = 10in the first thread, expecting that once 'y' shows up as updated in the second thread, 'x' is also updated. - But this is racy.With this commit, 'y' is set non atomically after the atomic write.
This applies to all 6
tests: tests/5.1/atomic/test_atomic_fail_{acquire,relexed,seq_cst}.{c,F90}.