Fix build error in zrotg.c with FUNCTION_PROFILE=1 from Makefile.rule - #5944
Merged
martin-frbg merged 1 commit intoJul 30, 2026
Merged
Conversation
Add missing FUNCTION_PROFILE_END / IDEBUG_END after all return
paths to properly close the brace opened by FUNCTION_PROFILE_START.
Use a do { … } while(0) wrapper so the macros stay outside any
nested block.
Collaborator
|
Thank you - this was probably broken in my effort to realign ROTG with changes in the reference implementation a few years ago. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When FUNCTION_PROFILE is enabled in Makefile.rule, zrotg.c fails to compile because FUNCTION_PROFILE_START introduces an unmatched opening brace. This PR inserts FUNCTION_PROFILE_END and IDEBUG_END at the single exit point behind a do-while(0) wrapper.