Skip to content

Add ThermoPower branch v4.0.0-dev to the CI #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndreaBartolini merged 5 commits into from
Mar 26, 2026
Merged

Add ThermoPower branch v4.0.0-dev to the CI #280

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
214c772
ThermoPower branch v4.0.0-dev added to installLibraries.mos
AndreaBartolini Mar 26, 2026
9d90ee0
ThermoPower branch v4.0.0-dev added to conf.json
AndreaBartolini Mar 26, 2026
3ec57fa
Update configs/conf.json
AndreaBartolini Mar 26, 2026
c86fc0a
Fixed wrong library version
AndreaBartolini Mar 26, 2026
1c09a8c
Fixed wrong revision in installLibraries.mos
AndreaBartolini Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .CI/installLibraries.mos
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ for l in {
{"ThermofluidStream", ""},
{"ThermofluidStream", "main"},
{"ThermoPower", "master"},
{"ThermoPower", "v4.0.0-dev"},
Copy link
Copy Markdown
Member

@AnHeuermann AnHeuermann Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the branch provides version v4.0.0 without the dev part, see
https://github.com/casella/ThermoPower/blob/v4.0.0-dev/ThermoPower%204.0.0/package.mo#L2124.

Image

Copy link
Copy Markdown
Contributor Author

@AndreaBartolini AndreaBartolini Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right... I've accepted your changes

Copy link
Copy Markdown
Member

@AnHeuermann AnHeuermann Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{"ThermoPower", "v4.0.0-dev"},
{"ThermoPower", "4.0.0-dev"},

My bad, I looked at the actual JSON and it should be this one.

{"ThermoSysPro", "master"},
{"TILMedia", "main"},
{"TILMedia_AddOn_Tests", "main"},
Expand Down
5 changes: 5 additions & 0 deletions configs/conf.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,6 +565,11 @@
"library":"ThermoPower",
"optlevel":"-Os -march=native"
},
{
"library":"ThermoPower",
"libraryVersion":"v4.0.0-dev",
Comment thread
AnHeuermann marked this conversation as resolved.
Outdated
"optlevel":"-Os -march=native"
},
{
"library":"ThermoSysPro",
"libraryVersion":"master",
Expand Down
Loading