Skip to content

[com4] use custom path only for DEM (for CAIROS)#1129

Merged
fso42 merged 1 commit into
masterfrom
FP_useCustomPathDEM
May 14, 2025
Merged

[com4] use custom path only for DEM (for CAIROS)#1129
fso42 merged 1 commit into
masterfrom
FP_useCustomPathDEM

Conversation

@PaulaSp3
Copy link
Copy Markdown
Contributor

@PaulaSp3 PaulaSp3 commented May 14, 2025

No description provided.

@PaulaSp3 PaulaSp3 requested a review from ahuber-bfw May 14, 2025 07:40
@qltysh
Copy link
Copy Markdown
Contributor

qltysh Bot commented May 14, 2025 •
edited
Loading

Diff Coverage: Not applicable. There was no coverage data reported for the files in this diff.

Total Coverage: This PR will not change total coverage.

🛟 Help

  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@fso42 fso42 added the enhancement New feature or request label May 14, 2025
@fso42 fso42 added this to the Version 1.13 milestone May 14, 2025
@fso42 fso42 changed the title use custom path only for DEM (for CAIROS) [com4] use custom path only for DEM (for CAIROS) May 14, 2025
fso42
fso42 reviewed May 14, 2025
View reviewed changes
Comment thread avaframe/runCom4FlowPy.py Outdated
ahuber-bfw
ahuber-bfw reviewed May 14, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ahuber-bfw ahuber-bfw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PaulaSp3: schaut gut aus - den use-case musst du mir mal erklären, bitte ;)

@PaulaSp3 PaulaSp3 assigned fso42 and unassigned ahuber-bfw May 14, 2025
@PaulaSp3
custom path only for DEM
2b4dce7 
use existing function for getting DEM path
@PaulaSp3 PaulaSp3 force-pushed the FP_useCustomPathDEM branch from ea2b1b2 to 2b4dce7 Compare May 14, 2025 12:06
@qlty-cloud-legacy
Copy link
Copy Markdown

qlty-cloud-legacy Bot commented May 14, 2025

Code Climate has analyzed commit 2b4dce7 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 69.8% (0.0% change).

View more on Code Climate.

@fso42 fso42 merged commit 7cebbb0 into master May 14, 2025
7 checks passed
@fso42 fso42 deleted the FP_useCustomPathDEM branch May 14, 2025 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahuber-bfw ahuber-bfw ahuber-bfw left review comments

@fso42 fso42 fso42 approved these changes

Assignees

@fso42 fso42

@PaulaSp3 PaulaSp3

Labels

enhancement New feature or request

Projects

None yet

Milestone

Version 1.13

Development

Successfully merging this pull request may close these issues.

3 participants

@PaulaSp3 @fso42 @ahuber-bfw