[com8] Add initial com8MotPSA and com9MoTVoellmy #1149
Merged
Merged
Conversation
Contributor
❌ 27 blocking issues (31 total)
@qltysh one-click actions:
|
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
Contributor
|
Diff Coverage: The code coverage on the diff in this pull request is 55.4%. Total Coverage: This PR will decrease coverage by 0.95%. File Coverage Changes
🛟 Help
|
fso42
changed the title
fso42
changed the title
Contributor
Author
|
Standardtests ok, apart from know res issues |
awirb
reviewed
Jul 4, 2025
Contributor
awirb
left a comment
awirb
left a comment
There was a problem hiding this comment.
I didn't check any files in com8 or com9
Initial implementation of the com8MoTPSA module. Includes a basic run script, configuration file parsing, and a function to convert the configuration file to the RCF format required by the MoT-PSA binary. A README_dev file is also added with basic instructions.
… (comMotPSAInitial) - First working conversion feat(com8MoTPSA): Enhance logging and configuration handling (com8MoTPSA) ; working commit feat(com1DFA, com8MoTPSA): Refactor simulation file handling and configuration management (comMotPSAInitialA) ; working commit
…guration parameters (comMotPSAInitial) - Add a function to rewrite DEM NaN values to 0.0 and update the nodata value in the header. - Update MoT-PSA configuration parameters to use the modified DEM and set release depth filenames. - Convert release shape to raster with values for the current simulation. - Write release lines to raster files. - Increase precision of raster output to 3 decimal places. feat(com8MoTPSA): Enhance output handling and add bed input files (com8MoTPSA) - Adds dummy bed depth, deposition, and shear strength files to the MoT-PSA configuration. These files are currently populated with empty rasters. This prepares the framework for future incorporation of these parameters into the simulation. Working commit: squash
…ocessing (comMotPSAInitial) - Implemented preprocessing steps for com8MoTPSA, including creating rcf files and preparing input data. - Implemented postprocessing steps for com8MoTPSA, including copying result files to the output directory. - Parallelized the execution of MoT-PSA simulations. feat(com8MoTPSA): Enhance postprocessing and add plotting (comMotPSAInitial) - Enhance postprocessing to copy ppr, pfd, and pfv files with updated naming conventions. - Update plotUtilsCfg.ini with configurations for pfd plotting. feat(com8MoTPSA): Update file handling and increase simulation time (comMotPSAInitial) - Changed working directory to the script's directory before executing MoT-PSA. - Removed "./" prefix from file paths in the configuration file to use absolute paths. - Set releaseL2 to a zero raster instead of releaseLine raster data. - Increased simulation time in `com8MoTPSACfg.ini` from 100.0s to 1000.0s. adjust how release files are used
…d special characters runAna4ProbAna.py with com8MoTPSA module (runAna4ProbAnaCom8MoTPSA.py), add sections to com8MoTPSA.ini and probAnaCfg.ini, and introduce modname Pass module instead of modName and add hepler functions to simplify functions: `checkParameterInConfig` and `fetchParameterSection` Change handling of friction index to volume index for com8MoTPSA Add `renameDuplicates` to handle duplicate column names in DataFrame and Simplify configuration-appending by generalizing section (add all sections) Change naming of outputlayer (dfa/psa), revert merging to original version (merge on simName) refactor(core): improve code readability and fix minor issues - Remove unused parameters in `probAna.py` and update method names for clarity. - Fix a conditional statement in `com1DFA.py` for better compatibility. - Add a missing newline and correct whitespace formatting in `aimecTools.py`. - Maintain consistent casing in `plotUtilsCfg.ini`. refactor(com8MoTPSA): improve code formatting and readability -
refactor(com1DFA): fix field initialization - Add `cResRasterOrig` and `detRasterOrig` fields for clarity. - Initialize `tPlot` field for particles handling. - Streamline `DAM` file path assignment to reduce redundant code. refactor(rasterUtils): remove `decimal_precision` parameter feat(cfgUtils): add `cfgToRcf` function for converting configurations to RCF format - Added a new utility function `cfgToRcf` in `cfgUtils.py` to convert `ConfigParser` objects to the RCF format required by NGI MoT. - Removed the duplicated implementation of `cfgToRcf` from `com8MoTPSA.py` and integrated the new utility. refactor(com1DFA, com8MoTPSA): qlty fmt refactor(com8MoTPSA): remove unused `pandas` import
… and postprocessing - Added `com9MoTVoellmy` module for running MoT-Voellmy simulations - Implemented preprocessing to generate RCF configuration files and prepare input data - Integrated parallel processing for simulation execution
- Remove this in future for a direct compilation feat(MANIFEST): include MoT-Voellmy executables in package distribution
…versions chore(pyproject): update `cibuildwheel` configuration for repair-wheel-command fix(com9MoTVoellmy): correct Windows executable path
…Values` and `copyMoTFiles` test(cfgUtils): add unit tests for configuration utilities test(probAna): add unit tests for `createSample` function with various sampling methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Might not run yet