[com4]: output for release area information by PaulaSp3 · Pull Request #1213 · OpenNHM/AvaFrame

PaulaSp3 · 2025-11-20T09:15:14Z

rasters are only merged if they are written as output.
computation time (for my example): +25%
new outputs:
- affected area for a segmented release area (that is marked by a release ID) (polygon)
- Rel Id count (how many release areas - marked with a release ID) hit a cell (raster)
outputs that were new within this PR, but are deleted with this commit b8be3c9 again and could be restored with this commit:
- mimimum volume of release area (raster)
- maximum volume of release area (raster)
required input data (for these outputs):
- the release ID is given as a raster (the release ID is the raster value). Cells with the same release ID belong the same release area. The raster is provided in Inputs/RELID.
added tests for various functions for tiling and merging the tiles

qltysh · 2025-11-20T09:16:35Z

All good ✅

qltysh · 2025-11-25T10:32:49Z

Coverage Impact

⬆️ Merging this pull request will increase total coverage on master by 0.12%.

Modified Files with Diff Coverage (4)

File	% Diff	Uncovered Line #s
avaframe/com4FlowPy/flowCore.py	35.8%	147-378, 506, 518...
avaframe/com4FlowPy/splitAndMerge.py	88.1%	212-217, 230-231, 237
avaframe/com4FlowPy/flowClass.py	53.8%	124-218, 275-289...
avaframe/com4FlowPy/com4FlowPy.py	0.0%	58-894
Total	33.3%

🤖 Increase coverage with AI coding...

In the `PS_FP_outputRelInfo` branch, add test coverage for this new code:

- `avaframe/com4FlowPy/com4FlowPy.py` -- Line 58-894
- `avaframe/com4FlowPy/flowClass.py` -- Lines 124-218, 275-289, and 468-472
- `avaframe/com4FlowPy/flowCore.py` -- Lines 147-378, 506, 518, 523, 530, 533, 547, 584, and 618-622
- `avaframe/com4FlowPy/splitAndMerge.py` -- Lines 212-217, 230-231, and 237

🚦 See full report on Qlty Cloud »

🛟 Help

Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.
Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.
File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)
- Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

ahuber-bfw

Hey @PaulaSp3,

Cool features (esp. the releaseID to Polygon feature :) )

only some questions/remarks:

maybe you can add some tests for the new functions in splitAndMerge.py in the test_com4FlowPy.py file
handling of additional output arrays in flowCore.py --> to be consistent with the method used for other optional outupts (e.g. infra, forestInteraction) maybe we could only initiate the required arrays, if the option is set in the .ini - else just assign None?
regarding the option to have a relVolMin and relVolMax output
- are there use-cases, where this is interesting and you don't also use the relID option at the same time?
- if this is only used togehter with the relID option, then this could probably be implemented at a higher level or in a post-processing step without need for modification in flowCore.py and flowClass.py

ahuber-bfw

looks good!
only some minor comments left - see below.

…ess path still in progress relVolMin and relVolMax as output correct position for relId delete print small change fix bug pathPolygons as output rename function tidy up try to keep RAM as small as possible print a warning if the output in cfg is not completly valid small corrections correct bugs and doc update docu adapt pytest delete unused package Update com4FlowPy.py deleteTempFolder - small BugFix and adaptation for releaseID functionality add tests for tiling, merging of tiles fixed bug extend split and merge test add test for dictToPolygon fix bug format and test fix

comments AH Update avaframe/tests/test_com4FlowPy.py Co-authored-by: qltysh[bot] <168846912+qltysh[bot]@users.noreply.github.com> fix bug clean and make polygon geometry valid delete temp files delete unued import comments AH Update avaframe/tests/test_com4FlowPy.py Co-authored-by: ahuber-bfw <112931921+ahuber-bfw@users.noreply.github.com> comment AH

fso42 · 2026-06-02T14:53:04Z

Standardtests ident apart from known com5

PaulaSp3 self-assigned this Nov 20, 2025

PaulaSp3 added enhancement New feature or request flowPyDev Ideas for future development labels Nov 20, 2025

qltysh Bot reviewed Nov 20, 2025

View reviewed changes

PaulaSp3 requested a review from ahuber-bfw November 25, 2025 10:18

qltysh Bot reviewed Nov 25, 2025

View reviewed changes

PaulaSp3 force-pushed the PS_FP_outputRelInfo branch from 9d893b8 to e75f10d Compare January 9, 2026 14:04

qltysh Bot reviewed Jan 9, 2026

View reviewed changes

PaulaSp3 force-pushed the PS_FP_outputRelInfo branch from e75f10d to e5091f8 Compare February 19, 2026 09:19

qltysh Bot reviewed Feb 19, 2026

View reviewed changes

Comment thread avaframe/com4FlowPy/splitAndMerge.py

PaulaSp3 force-pushed the PS_FP_outputRelInfo branch from e5091f8 to ae29065 Compare February 19, 2026 09:22

PaulaSp3 force-pushed the PS_FP_outputRelInfo branch from ae29065 to c1ae153 Compare April 15, 2026 09:51

ahuber-bfw requested changes Apr 27, 2026

View reviewed changes

ahuber-bfw reviewed May 4, 2026

View reviewed changes

Comment thread avaframe/runCom4FlowPy.py

ahuber-bfw reviewed May 4, 2026

View reviewed changes

Comment thread avaframe/com4FlowPy/com4FlowPyCfg.ini Outdated

PaulaSp3 force-pushed the PS_FP_outputRelInfo branch from 4f4a576 to 8b69944 Compare May 13, 2026 13:10

qltysh Bot reviewed May 18, 2026

View reviewed changes

Comment thread avaframe/tests/test_com4FlowPy.py Outdated

PaulaSp3 force-pushed the PS_FP_outputRelInfo branch from edcbc76 to dbc6b26 Compare May 18, 2026 12:43

qltysh Bot reviewed May 18, 2026

View reviewed changes

Comment thread avaframe/tests/test_com4FlowPy.py Outdated

qltysh Bot reviewed May 18, 2026

View reviewed changes

Comment thread avaframe/com4FlowPy/flowClass.py

Comment thread avaframe/com4FlowPy/flowClass.py

PaulaSp3 force-pushed the PS_FP_outputRelInfo branch from a42be9d to c628585 Compare May 18, 2026 17:05

qltysh Bot reviewed May 18, 2026

View reviewed changes

Comment thread avaframe/com4FlowPy/splitAndMerge.py Outdated

PaulaSp3 force-pushed the PS_FP_outputRelInfo branch from c628585 to 643cf37 Compare May 20, 2026 09:57

PaulaSp3 force-pushed the PS_FP_outputRelInfo branch 2 times, most recently from 13d6ec4 to 71dd27e Compare May 21, 2026 08:51

PaulaSp3 force-pushed the PS_FP_outputRelInfo branch from 71dd27e to 5d696bf Compare June 1, 2026 09:47

ahuber-bfw approved these changes Jun 2, 2026

View reviewed changes

Comment thread avaframe/com4FlowPy/flowCore.py Outdated

Comment thread avaframe/tests/test_com4FlowPy.py Outdated

Comment thread avaframe/com4FlowPy/splitAndMerge.py Outdated

Comment thread avaframe/tests/data/testCom4/refPolygon_manipulated.qmd Outdated

PaulaSp3 force-pushed the PS_FP_outputRelInfo branch from a16ac02 to 266eb0e Compare June 2, 2026 11:51

PaulaSp3 assigned fso42 and unassigned PaulaSp3 Jun 2, 2026

PaulaSp3 added 2 commits June 2, 2026 16:26

fso42 force-pushed the PS_FP_outputRelInfo branch from 266eb0e to 62e9eeb Compare June 2, 2026 14:26

fso42 merged commit bab756c into master Jun 2, 2026
3 of 4 checks passed

fso42 deleted the PS_FP_outputRelInfo branch June 2, 2026 14:53

Conversation

PaulaSp3 commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qltysh Bot commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

qltysh Bot commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ahuber-bfw left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PaulaSp3 commented Nov 20, 2025 •

edited

Loading

qltysh Bot commented Nov 20, 2025 •

edited

Loading

qltysh Bot commented Nov 25, 2025 •

edited

Loading