Spi monitor rename#356
Open
chrysh wants to merge 2 commits into
Open
Conversation
The board-level monitor module orchestrates the SPI monitor (SPIPF) and SCU mux control for SPI flash protection. Rename the file monitor.rs -> spi_monitor.rs and the struct Ast1060Monitor -> Ast1060SpiMonitor, and update the module path/re-export in lib.rs and the srcs list in BUILD.bazel, to reflect that it is specifically an SPI monitor. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Christina Quast <christina.quast@9elements.com>
Disambiguate the SPI monitor API from an upcoming BootMonitor subsystem so the two never collide. Rename in the spimonitor crate: Monitor (trait) -> SpiMonitorControl MonitorInstance -> SpiMonitorId (avoids clash with scu::SpiMonitorInstance) MonitorStatus -> SpiMonitorStatus MonitorState -> SpiMonitorState MonitorPolicy -> SpiMonitorPolicy The SpimWiringError::Monitor and SpiMonitorError::MonitorNotFound enum variants are left as-is; they are namespaced by their enum and cannot collide. Update the board impl accordingly. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Christina Quast <christina.quast@9elements.com>
Author
|
@rusty1968 @yvettewu1 Can you have a look? The renaming is necessary to disambiguate from the BootMonitor. |
yvettewu1
approved these changes
Jul 17, 2026
chrysh
marked this pull request as ready for review
July 18, 2026 11:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiles and passes the following tests:
bazelisk test --config=virt_ast10x0 //target/ast10x0/tests/spimonitor/...