fix(registry): fall back to default SIN_SKILLS_DIR when env var is unset#78
Merged
Conversation
The registry used os.Getenv(SIN_SKILLS_DIR) directly, which is empty by default. skillmgr installs skills into ~/.local/share/sin-code/skills when SIN_SKILLS_DIR is unset, so the registry now uses the same default path. This makes the websearch Go-native skill discoverable out of the box after 'sin-code skill install websearch' without requiring SIN_SKILLS_DIR to be set. Adds a test that verifies the default skills dir is used when the env var is unset and the binary exists there.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🏆 CEO Audit — A+ (100.0/100)
📥 Download full report (Markdown)
|
🏆 CEO Audit — A+ (100.0/100)
📥 Download full report (Markdown) Run ID:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The registry used os.Getenv(SIN_SKILLS_DIR) directly, which is empty by default. skillmgr installs skills into ~/.local/share/sin-code/skills when SIN_SKILLS_DIR is unset, so the registry now uses the same default path. This makes the websearch Go-native skill discoverable out of the box after 'sin-code skill install websearch' without requiring SIN_SKILLS_DIR to be set.