Extension of traffic lights and signs regarding model references#423
Merged
Conversation
Contributor
|
Makes sense to me, since it makes traffic signs and lights consitent with other objects. |
|
Output from CCB meeting - 25.11.2020 Actions: |
Contributor
|
documentation review is done. Looks good. I have nothing to change. |
|
Output from CCB meeting - 09.12.2020
|
Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
503696a to
ab2a02c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference to a related issue in the repository
No related issue.
Add a description
Beside the model_references in stationary and moving object, it can be helpful to have a reference packed within traffic lights and traffic signs (main sign + supplementary sign).
The model_reference can be used e.g. to tell which 3D-model should be visualized.
Some questions to ask:
What is this change?
Added three model_references
What does it fix? Is this a bug fix or a feature? Does it break any existing functionality or force me to update to a new version?
It's a new feature the helps to use osi for visualization.
How has it been tested?
It works, testing was company internally.
Mention a member
@pmai , @engelben
This would be a PR for the planned CCB.
Check the checklist