set default c11 compiler for apple machines#466
Conversation
pmai
left a comment
There was a problem hiding this comment.
I think whether C++ 11 is needed or not depends more on the protobuf implementation you will use (i.e. protobuf <3.6 does not need it, protobuf >3.6 needs it), than it does on OSI itself.
That being said, since 3.6 has been out now for more than 2.5 years, and C++11 for nearing 10, it might be a good idea to switch to C++11 by default (people who want/need to support pre-C++11 can just override the option, and supply suitable protobuf versions). The OSMP examples already require C++ 11.
However if we do so, we should switch across all platforms (there is nothing Apple-specific about this): Could you refactor the PR to just do this unconditionally? Thank you.
pmai
left a comment
There was a problem hiding this comment.
Looking good to me, ready for CCB discussion...
|
Output CCB meeting 03.02.2021
|
Ensure compatibility with post 3.5 versions of protobuf out of the box. Note that nothing in OSI per see requires C++ 11, so users catering to older platforms using older protobuf releases can switch this back if needed using the normal CMake configuration mechanisms. Signed-off-by: Carsten Drösser <carsten.droesser@gmail.com>
Reference to a related issue in the repository
No open issue for this pull-request.
Add a description
Tell cmake which compiler to use on apple machines: Building the project out of the box on apple machines will cause Cmake to fail. Setting the correct default compiler will fix this issue. Extending CMakeLists.txt fixes the build-process and enables an 'out of the box' build without errors.
Mention a member
@pmai
Check the checklist
Crossed entries were considered as not required.