Documentation/ground clearance bb relation#470
Merged
Conversation
PhRosenberger
force-pushed
the
documentation/ground-clearance_bb_relation
branch
2 times, most recently
from
a69387f to
446cc34
Compare
kmeids
reviewed
Feb 5, 2021
kmeids
left a comment
kmeids
left a comment
There was a problem hiding this comment.
All good from my side.
A documentation review by the service provider is to be done.
@max-rosin could you please take a look?
kmeids
added
Documentation
Contributor
|
Reviewed documentation changes and simplified language a bit (remove brackets and abbreviations, split longer sentences). |
kmeids
added
ReadyForCCBReview
kmeids
approved these changes
Feb 11, 2021
kmeids
left a comment
kmeids
left a comment
There was a problem hiding this comment.
Approved during the CBB meeting 11.02.2021
kmeids
added
ReadyToMerge
|
Output from CCB meeting 11.02.2021:
|
Update osi_detectedobject.proto, ground_clearance is included in base().height. Signed-off-by: Philipp Rosenberger <philipp.rosenberger@epro-systems.de>
Signed-off-by: Philipp Rosenberger <philipp.rosenberger@epro-systems.de>
Signed-off-by: Maximilian Rosin <maximilian.rosin@parson-europe.com> Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
pmai
force-pushed
the
documentation/ground-clearance_bb_relation
branch
from
685509e to
c7b7195
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference to a related issue in the repository
Resolves #467.
Add a description
Finetuning of the description of ground_clearance and its relation to the bounding box height.
Mention a member
Has been discussed with @kmeids and @pmai .
Check the checklist