Make handling of enums in rules check more robust#474
Merged
Conversation
Earlier versions of this check erroneously treated the end of an enum as the end of its enclosing message, leading to problems with nested enums if they appeared not at the end of its enclosing messages. Signed-off-by: Pierre R. Mai <pmai@pmsf.de>
pmai
added
Bug
kmeids
approved these changes
Feb 11, 2021
kmeids
left a comment
kmeids
left a comment
There was a problem hiding this comment.
Approved during the CCB meeting 11.02.2021
kmeids
added
ReadyToMerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Earlier versions of this check erroneously treated the end of an enum
as the end of its enclosing message, leading to problems with nested
enums if they appeared not at the end of its enclosing messages.
Signed-off-by: Pierre R. Mai pmai@pmsf.de