Moved different action definitions into message trafficAction.#477
Merged
Conversation
ThomasNaderBMW
force-pushed
the
update/restructure_trafficActions
branch
from
c64dbfd to
5c3197d
Compare
Contributor
Author
|
Ah yes and I tried to correct the code style of some parts. |
ThomasNaderBMW
force-pushed
the
update/restructure_trafficActions
branch
2 times, most recently
from
d237eb3 to
b7370fe
Compare
clemenshabedank
force-pushed
the
update/restructure_trafficActions
branch
from
ee9fd5f to
8d709dd
Compare
clemenshabedank
added
the
ReadyForCCBReview
clemenshabedank
approved these changes
Feb 11, 2021
|
Output from CCB meeting 11.02.2021
|
kmeids
added
ReadyToMerge
Signed-off-by: Thomas Nader <thomas.nader@bmw.de>
Re-used FollowingMode, DynamicsShape by putting it from the Actions itself one nesting level higher; restructured the whole message for more clarity; clarified the description for the bool follow in LongitudinalDistanceAction and LateralDistanceAction Signed-off-by: Clemens Habedank <clements.habedank@partner.bmw.de>
pmai
force-pushed
the
update/restructure_trafficActions
branch
from
8d709dd to
d77abe6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nader Thomas thomas.nader@bmw.de
Reference to a related issue in the repository
As discussed in the CCB-Meeting.
Add a description
Restructuring of the different traffic action definitions as discussed in the CCB-Meeting.
==> To make the code more structured and give a better overview (especially by implementing).
Some questions to ask:
What is this change?
Moved the different traffic action definitions in message TrafficAction as discussed in the CCB-Meeting.
What does it fix?
Is this a bug fix or a feature? Does it break any existing functionality or force me to update to a new version?
How has it been tested?
Mention a member
Add @mentions of the person or team responsible for reviewing proposed changes.
Check the checklist