Add steering wheel angle#479
Merged
Merged
Conversation
ThomasNaderBMW
force-pushed
the
feature/steering_wheel_angle
branch
from
93b77f3 to
6b6d5c1
Compare
ThomasNaderBMW
added
the
ReadyForCCBReview
kmeids
approved these changes
Feb 11, 2021
kmeids
left a comment
kmeids
left a comment
There was a problem hiding this comment.
Approved during the CCB meeting 11.02.2021.
|
Output of CCB meeting 11.02.2021
|
kmeids
added
ReadyToMerge
pmai
force-pushed
the
feature/steering_wheel_angle
branch
from
aa47d20 to
45146fb
Compare
Signed-off-by: Thomas Nader <thomas.nader@bmw.de>
pmai
force-pushed
the
feature/steering_wheel_angle
branch
from
45146fb to
8c35f1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a description
The value is needed for visualization needs. To see how the steering wheel moves from other cars, but also your own (especially VR, when you sit in the car.
It can not be derived from the wheel angle in an accurate way.
Some questions to ask:
What is this change? What does it fix?
The value is needed for visualization needs. To see how the steering wheel moves from other cars, but also your own (especially VR, when you sit in the car.
It can not be derived from the wheel angle in an accurate way.
Is this a bug fix or a feature? Does it break any existing functionality or force me to update to a new version?
New feature.
How has it been tested?
In another branch the signal was implemented and tested.
Check the checklist