Do not display the Flyto/JumpTo/Frame buttons in the kebab menu for SceneGraphNodes that are not focussable#227
Merged
Merged
Conversation
…ceneGraphNodes that are not focussable
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents navigation actions (FlyTo/JumpTo/Frame) from being shown in the SceneGraphNode kebab (“more”) menu when a scene graph node is marked as non-focusable, aligning the menu behavior with the already-hidden focus button and avoiding invalid navigation interactions.
Changes:
- Add
useIsSgnFocusable(uri)to determine focusability in the more-menu. - Conditionally render Fly/Jump/Frame
NodeNavigationButtons only when the node is focusable.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
engbergandreas
approved these changes
Jun 11, 2026
Co-authored-by: Andreas Engberg <48772850+engbergandreas@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The focus button in the menu for non-focussable objects was hidden, but it was still possible to break things by opening the Kebab menu and select the navigation buttons there. This PR doesn't add these buttons if the scene graph node is marked as non-focussable.
Before:
After:
