Skip to content

Fallback to using uname machine for hosts using uutils/coreutils#97

Closed
alavaliant wants to merge 2 commits intoOpenVoxProject:mainfrom
alavaliant:fallback_to_uname_machine_for_uutils_coreutils
Closed

Fallback to using uname machine for hosts using uutils/coreutils#97
alavaliant wants to merge 2 commits intoOpenVoxProject:mainfrom
alavaliant:fallback_to_uname_machine_for_uutils_coreutils

Conversation

@alavaliant
Copy link
Copy Markdown

@alavaliant alavaliant commented Apr 1, 2026

Short description

Set the uname resolver to fallback to using the uname machine value to replace uname processor. If the uutils/coreutils version of uname is being used (which returns unknown for uname -p). This fixes various facts like processor.extensions and processor.isa on Distributions like Ubuntu 26.04 which use uutils/coreutils by default.

(This PR follows on from #96 )

Checklist

I have:

  • [* ] read the CONTRIBUTING.md document
  • [ *] read and accepted the Developer Certificate of Origin document and added a Signed-off-by annotation to each of my commits
  • [ *] tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Signed-off-by: Jason Alavaliant <alavaliant@ra09.com>
…ck code

Signed-off-by: Jason Alavaliant <alavaliant@ra09.com>
@alavaliant
Copy link
Copy Markdown
Author

Sorry, while I tested that code/facter was running as expected with the changes. I completely missed the trailing space when I copied and pasted the code in from #96 I've installed rubocop now and verified that the latest version of the file doesn't report any offenses. So hopefully the tests should all pass now.

I have been trying to get the full set of tests running locally on my machine. But following the https://voxpupuli.org/docs/how_to_run_tests/#installing-dependencies instructions on my debian 13.4 machine. While all the prerequisite setup runs without error. Trying to run commands from the bundle afterwards all seem to result in error like;

$ bundle exec rake lint
rake aborted!
LoadError: cannot load such file -- rspec/core/rake_task (LoadError)
/home/alavaliant/openfact/Rakefile:5:in `<top (required)>'
/home/alavaliant/openfact/.vendor/bundle/ruby/3.3.0/gems/rake-13.3.1/exe/rake:27:in `<top (required)>'
(See full trace by running task with --trace)

Which I've not traced the cause for yet.

@alavaliant alavaliant closed this Apr 1, 2026
@alavaliant alavaliant deleted the fallback_to_uname_machine_for_uutils_coreutils branch April 1, 2026 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants