Fallback to using uname machine for hosts using uutils/coreutils#97
Closed
alavaliant wants to merge 2 commits intoOpenVoxProject:mainfrom
Closed
Fallback to using uname machine for hosts using uutils/coreutils#97alavaliant wants to merge 2 commits intoOpenVoxProject:mainfrom
alavaliant wants to merge 2 commits intoOpenVoxProject:mainfrom
Conversation
Signed-off-by: Jason Alavaliant <alavaliant@ra09.com>
nmburgan
approved these changes
Apr 1, 2026
…ck code Signed-off-by: Jason Alavaliant <alavaliant@ra09.com>
Author
|
Sorry, while I tested that code/facter was running as expected with the changes. I completely missed the trailing space when I copied and pasted the code in from #96 I've installed rubocop now and verified that the latest version of the file doesn't report any offenses. So hopefully the tests should all pass now. I have been trying to get the full set of tests running locally on my machine. But following the https://voxpupuli.org/docs/how_to_run_tests/#installing-dependencies instructions on my debian 13.4 machine. While all the prerequisite setup runs without error. Trying to run commands from the bundle afterwards all seem to result in error like; $ bundle exec rake lint
rake aborted!
LoadError: cannot load such file -- rspec/core/rake_task (LoadError)
/home/alavaliant/openfact/Rakefile:5:in `<top (required)>'
/home/alavaliant/openfact/.vendor/bundle/ruby/3.3.0/gems/rake-13.3.1/exe/rake:27:in `<top (required)>'
(See full trace by running task with --trace)Which I've not traced the cause for yet. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
Set the uname resolver to fallback to using the uname machine value to replace uname processor. If the uutils/coreutils version of uname is being used (which returns unknown for uname -p). This fixes various facts like processor.extensions and processor.isa on Distributions like Ubuntu 26.04 which use uutils/coreutils by default.
(This PR follows on from #96 )
Checklist
I have:
Signed-off-byannotation to each of my commits