fix: remove redundant donor record fetch in claim_refund (#79)#84
Merged
Alqku merged 1 commit intoJun 28, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
claim_refundwas reading the donor record from persistent storage twice in immediate succession. The first read was bound to_donor_recordand immediately discarded, doubling the host-storage I/O (including abump_persistentTTL extension call insideget_donor) on an already-expensive refund path.Changes
_donor_recordbinding fromclaim_refundincampaign/src/lib.rsTesting
Existing campaign contract tests pass without modification — the change is pure dead code removal with no behavioural impact.
Closes #79