Skip to content

fix: remove dead storage helpers in campaign/src/storage.rs (#80) #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Xhristin3 wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −52
Open

fix: remove dead storage helpers in campaign/src/storage.rs (#80) #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 0 additions & 50 deletions campaign/src/storage.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,29 +305,6 @@ pub fn storage_increment_asset_raised(env: &Env, token: &Address, delta: i128) -
new_total
}

// ─── Contract status (temporary) ─────────────────────────────────────────────

/// Load the transient contract status flag.
/// Returns `None` if the entry has expired or was never set.
pub fn get_contract_status(env: &Env) -> Option<u32> {
let key = DataKey::ContractStatus;
let value = env.storage().temporary().get(&key)?;
env.storage()
.temporary()
.extend_ttl(&key, TEMPORARY_BUMP_THRESHOLD, TEMPORARY_TTL);
Some(value)
}

/// Persist the transient contract status flag with a fresh TTL.
pub fn set_contract_status(env: &Env, status: u32) {
let key = DataKey::ContractStatus;
env.storage().temporary().set(&key, &status);
// Set explicit TTL — temporary entries default to 1 ledger without this
env.storage()
.temporary()
.extend_ttl(&key, TEMPORARY_BUMP_THRESHOLD, TEMPORARY_TTL);
}

// ─── Re-entrancy lock (temporary) ────────────────────────────────────────────
//
// Soroban's transaction model prevents true re-entrancy, but cross-contract
Expand Down Expand Up @@ -371,30 +348,3 @@ pub fn set_frozen(env: &Env, frozen: bool) {
bump_persistent(env, &key);
}

// ─── Bulk TTL refresh ─────────────────────────────────────────────────────────

/// Refresh TTL for all core persistent keys in a single call.
/// Call this from a `bump_storage` admin function to prevent archival
/// during long-running campaigns.
pub fn bump_all_persistent(env: &Env, milestone_count: u32) {
let core_keys = [
DataKey::CampaignData,
DataKey::TotalRaised,
DataKey::DonationCount,
DataKey::UniqueDonorCount,
DataKey::ReleaseCount,
];

for key in &core_keys {
if env.storage().persistent().has(key) {
bump_persistent(env, key);
}
}

for i in 0..milestone_count {
let key = DataKey::MilestoneData(i);
if env.storage().persistent().has(&key) {
bump_persistent(env, &key);
}
}
}
2 changes: 0 additions & 2 deletions campaign/src/types.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,8 +296,6 @@ pub enum DataKey {
ReleaseCount,

// ── Temporary ───────────────────────────────────────────────────────────
/// Transient campaign status flag used during state transitions.
ContractStatus,
/// Re-entrancy guard; present = locked, absent = unlocked.
ReentrancyLock,
/// Freeze flag; present and true = contract is frozen, mutating ops blocked.
Expand Down
Loading