Tighten daemon route auth identity handoff#1471
Merged
Jurij89 merged 10 commits intoJul 6, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RequestContext: internal route handlers now receive a requiredrequestIdentity, while plugin compatibility keeps the public field optional.handleRequestfor/api/agent/identityand/api/context-graph/:id/sign-join, so the tests fail if production dispatcher wiring drops the accepted dashboard principal.Related
Files changed
packages/cli/src/daemon/lifecycle.tsauthResult.requestAuthContextinto SSE resolution and route dispatch.packages/cli/src/daemon/handle-request.tspackages/cli/src/daemon/route-request-identity.tspackages/cli/src/daemon/dashboard-sse-session.tspackages/cli/src/daemon/routes/*InternalRequestContext; userequestIdentitydirectly in the agent identity and sign-join helpers.packages/cli/test/dashboard-session-test-harness.tshandleRequestfor the two production endpoints under review.Test plan
cd packages/cli && pnpm exec vitest run test/auth.test.ts test/dashboard-login.test.ts test/dashboard-session-auth-source.test.ts test/dashboard-session-cookie.test.ts test/dashboard-session-store.test.ts test/dashboard-session.test.ts test/route-request-identity-dashboard.test.ts --config vitest.unit.config.tscd packages/cli && pnpm exec tsc --noEmit --pretty falsegit diff --check