🔒 [security fix] Resolve DOM-based XSS in post titles and enable markdown sanitization#2
Conversation
…ization - Replace `dangerouslySetInnerHTML` with safe React interpolation for post titles in multiple components. - Enable `sanitize: true` in `remark-html` to ensure markdown content is safely converted to HTML. - Restore `package-lock.json` to maintain deterministic builds. Co-authored-by: OscarPastry <181119116+OscarPastry@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 participant
This PR addresses a DOM-based XSS vulnerability where post titles were rendered using
dangerouslySetInnerHTMLwith unsanitized data. It also proactively enables HTML sanitization for the markdown content processing to ensure overall site security.🎯 What:
dangerouslySetInnerHTMLinapp/secret-editor/page.js,app/posts/[slug]/page.js,app/components/HamburgerMenu.js, andapp/page.js.lib/posts.js.package-lock.json.Using
dangerouslySetInnerHTMLwith unsanitized user input (post titles) bypasses React's built-in XSS protection, allowing malicious scripts to be executed in the context of users' browsers. Similarly, unsanitized Markdown content could lead to XSS if malicious HTML is included.🛡️ Solution:
dangerouslySetInnerHTMLwith standard JSX interpolation ({post.title}), which automatically escapes content.remark-htmlto usesanitize: truewhen processing post content.PR created automatically by Jules for task 7165684055319761716 started by @OscarPastry