CI: build with all features#75
Open
xarantolus wants to merge 1 commit into
Open
Conversation
Member
|
Yes. I assume many of the features are outdated/broken. We want to avoid features altogether as the config system is the primary configuration mechanism and avoids lots of cargo limitations. We only need them when cargo forces us to use them. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Actions CI workflow to build/test documentation with all Cargo features enabled, aiming to prevent feature-gated compilation errors from slipping through CI.
Changes:
- Pass
--all-featuresto thejusttask invocation in the main CI matrix job.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| - name: Run task | ||
| run: just ${{ matrix.task }} | ||
| run: just ${{ matrix.task }} --all-features |
Member
There was a problem hiding this comment.
Note: That likely/unlikely is now on stable through cold_path. This needs a reimplementation altogether.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like quite some errors slipped through because we didn't enable all features when building / testing, this PR fixes and prevents that in the future.