resources: add response compose helpers#1070
Open
Bing-su wants to merge 4 commits into
Open
Conversation
github-actions
Bot
added
💬ko
💬cn
resources
There was a problem hiding this comment.
Pull request overview
Adds small composition helpers to the resources/responses.ts module to build static built-in responses by concatenating multiple LocaleText values with separators (with language fallback to en), plus unit tests validating composition behavior and severity handling.
Changes:
- Add
combineLocaleTexthelper to concatenate localized strings with per-language fallback. - Export new
composeandcompose3helpers to generate static built-in responses from 2 or 3LocaleTextparts. - Add unit tests covering composed output strings, severity selection, and locale fallbacks.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| resources/responses.ts | Introduces combineLocaleText plus exported compose / compose3 static response helpers. |
| test/unittests/responses_test.ts | Adds unit tests validating composed output strings and severity / locale fallback behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github-actions
Bot
added
needs-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1058
Add
composeandcompose3helper functions for combining LocaleText output strings into static built-in responses.Based on my experience so far, I am confident that as long as it is used only for simple and clear content, there will be no translation issues.