Skip to content

[FEATURE] replace inspect mode with split view#313

Merged
Brandon Liu (bdon) merged 5 commits into
mainfrom
split-view
Jun 1, 2026
Merged

[FEATURE] replace inspect mode with split view#313
Brandon Liu (bdon) merged 5 commits into
mainfrom
split-view

Conversation

@bdon
Copy link
Copy Markdown
Collaborator

@bdon Brandon Liu (bdon) commented May 22, 2026

  • default view has left map Explore mode and right map Inspect, so details like tranportation connectors are visible

Closes #309

@bdon Brandon Liu (bdon) requested a review from a team as a code owner May 22, 2026 19:11
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 22, 2026 •
edited
Loading

🗺️ Overture Explorer preview is live!
🌍 Preview https://staging.overturemaps.org/explore-site/pr/313/index.html
🕐 Updated 2026-05-29T16:06:55Z
📝 Commit 545bd50

Note

♻️ This preview updates automatically with each push to this PR.

@danabauer Dana Bauer (danabauer) self-requested a review May 26, 2026 15:13
@bdon Brandon Liu (bdon) mentioned this pull request May 27, 2026
Closed
@lowlydba
Copy link
Copy Markdown
Contributor

John McCall (lowlydba) commented May 27, 2026

🗳️ I think my vote is for this approach versus #315

@jjcfrancisco
Copy link
Copy Markdown
Member

Francisco Jiménez (jjcfrancisco) commented May 28, 2026

I agree with John McCall (@lowlydba) - the inset can be confusing in practice, whereas the split view feels more straightforward

@bdon
Copy link
Copy Markdown
Collaborator Author

Brandon Liu (bdon) commented May 28, 2026

I still need to make some additions to disable the Split View in iframe embed mode for the https://overturemaps.org/ landing page

Brandon Liu (bdon) added a commit that referenced this pull request May 28, 2026
@bdon
Add UI elements for changing the view to full-inspect or full-explore. [
b0cb32a 
#313]

Signed-off-by: Brandon Liu <bdon@bdon.org>
@bdon
[FEATURE] replace inspect mode with split view
439c733 
* default view has left map Explore mode and right map Inspect, so details like tranportation connectors are visible

Closes #309

Signed-off-by: Brandon Liu <bdon@bdon.org>
@bdon
Add UI elements for changing the view to full-inspect or full-explore. [
6083bc8 
#313]

Signed-off-by: Brandon Liu <bdon@bdon.org>
@bdon
Copy link
Copy Markdown
Collaborator Author

Brandon Liu (bdon) commented May 28, 2026

John McCall (@lowlydba) Francisco Jiménez (@jjcfrancisco) added a UI element for fully minimizing or maximizing explore/inspect in the middle:

https://staging.overturemaps.org/explore-site/pr/313/index.html#2/10/-80

Dana Bauer (@danabauer) the min/max can also be controlled via a URL parameter ?view=explore for embedding in an iFrame:

https://staging.overturemaps.org/explore-site/pr/313/index.html?view=explore#2/10/-80

We could also choose to make the embed on https://overturemaps.org show the Split View?

@lowlydba
Copy link
Copy Markdown
Contributor

John McCall (lowlydba) commented May 28, 2026

Nice! Split on the main page would be cool.

A minor UI nit - when the split is maximized in either direction (left, right) the UI control for it gets halved, so its a bit difficult to find the arrow to re-maximize:

{78E1C73A-50D6-451F-BB8D-BBC9A65DAF5B}

vs the full element:

{3F11E6AF-80DA-4AE7-AFDD-30D219E07621}

danabauer
Dana Bauer (danabauer) requested changes May 29, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@danabauer Dana Bauer (danabauer) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The split screen functionality is lovely but the control arrow gets lost at the edges (see John's comment). It's too difficult to flip it back.

@danabauer
Copy link
Copy Markdown
Collaborator

Dana Bauer (danabauer) commented May 29, 2026

We could also choose to make the embed on https://overturemaps.org show the Split View?

How would I do that?

@bdon
UI improvements
0958540 
* make sure the handle is always fully visible
* use the mode URL param to maintain the explore/inspect state
* properly layer the divider in the z-order

Closes #309

Signed-off-by: Brandon Liu <bdon@bdon.org>
@bdon
Copy link
Copy Markdown
Collaborator Author

Brandon Liu (bdon) commented May 29, 2026

We could also choose to make the embed on https://overturemaps.org show the Split View?

How would I do that?

I'll change the URL parameter to use the existing mode=explore key, so no changes are required.

@bdon
restore layer tree for inspect mode
27189d5 
Signed-off-by: Brandon Liu <bdon@bdon.org>
@bdon
Copy link
Copy Markdown
Collaborator Author

Brandon Liu (bdon) commented May 29, 2026

PR preview updated: https://staging.overturemaps.org/explore-site/pr/313/index.html

  • The split handle is always displayed even when in the extreme positions
  • Moving the split to the extremes also manages the ?mode=explore URL parameter
  • The layers selection tree now has a separate tab for explore and inspect, mirroring the current behavior
CleanShot 2026-05-29 at 12 25 26@2x

danabauer
Dana Bauer (danabauer) approved these changes Jun 1, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@danabauer Dana Bauer (danabauer) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing! Thanks, Brandon.

lowlydba
John McCall (lowlydba) approved these changes Jun 1, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@lowlydba John McCall (lowlydba) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Merge at will :shipit:

@bdon Brandon Liu (bdon) merged commit a8608bb into main Jun 1, 2026
12 checks passed
@bdon Brandon Liu (bdon) deleted the split-view branch June 1, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danabauer Dana Bauer (danabauer) danabauer approved these changes

@lowlydba John McCall (lowlydba) lowlydba approved these changes

@jjcfrancisco Francisco Jiménez (jjcfrancisco) jjcfrancisco approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Idea: use a split screen view to show both polished map and Inspect simultaneously

4 participants

@bdon @lowlydba @jjcfrancisco @danabauer