Skip to content

I added the function getOTPUrl to get the otp:// url from the secret#84

Open
CoffeeCodingGuy wants to merge 1 commit intoPHPGangsta:masterfrom
CoffeeCodingGuy:master
Open

I added the function getOTPUrl to get the otp:// url from the secret#84
CoffeeCodingGuy wants to merge 1 commit intoPHPGangsta:masterfrom
CoffeeCodingGuy:master

Conversation

@CoffeeCodingGuy
Copy link
Copy Markdown

since i don't want to send the screts to google, i created a function that outputs the otp: // url and then creates the barcode itself

The function works like the getQRCodeGoogleUrl function, but without the parameter $params.

@MarkMaldaba
Copy link
Copy Markdown

Good thinking.

I would also update getQRCodeGoogleUrl() to call this new function, rather than duplicating the functionality.

@CoffeeCodingGuy
Copy link
Copy Markdown
Author

I dont think so because the function is named getQRCodeGoogleUrl(). People who want a fast copy and paste solution are thinking that some data ist send to google.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants