[Frontend] Make the C++ trace the sole main TOG path; drop legacy ONNX TOG#277
Open
YWHyuk wants to merge 1 commit into
Open
[Frontend] Make the C++ trace the sole main TOG path; drop legacy ONNX TOG#277YWHyuk wants to merge 1 commit into
YWHyuk wants to merge 1 commit into
Conversation
…X TOG The main compile/sim path no longer generates or selects the legacy ONNX Tile-Operation-Graph. extension_codecache emits only trace.so + trace_cycles.tsv (the build-skip now keys on trace.so), and TOGSimulator.run_standalone always drives TOGSim with --trace_so. The TORCHSIM_LEGACY_TOG opt-in is removed from the frontend. The ONNX --models_list branch is kept solely for the STONNE sparse path (extension_op.py); TOGSim's C++ ONNX parser is untouched (separate PR). origins (which FX nodes a kernel came from) is preserved: logged per kernel run and recorded as a trailing "# origins:" line in trace_cycles.tsv -- the legacy ONNX TOG carried this as node metadata, and the C++ cycle-table loader stops at the comment so the current parser is unaffected. Also drop the dead tog_file param from mlir_gem5_compile_command, migrate scripts/chiplet.sh to --trace_so/--cycle_table (the trace path stubs per-tensor addresses and --attributes_list is no longer a Simulator option), and refresh the CLAUDE.md TOG-generation notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the C++ trace (trace.so + trace_cycles.tsv) the sole main TOG path and drop
the legacy ONNX Tile-Operation-Graph from the frontend codegen and the
frontend<->TOGSim connection.
trace.so); remove the legacy ONNX generation block and the TORCHSIM_LEGACY_TOG
opt-in.
--models_list branch is KEPT solely for the STONNE sparse path (extension_op.py).
and recorded as a trailing "# origins:" line in trace_cycles.tsv (the C++
cycle-table loader stops at the comment, so the current parser is unaffected).
Out of scope (kept)
Verification
Known limitation
The trace path stubs per-tensor addresses in TOGSim (build_trace_tilegraph), so
chiplet NoC / DRAM-partition accuracy is approximate until the trace path consumes
real addresses (TOGSim-side follow-up). --attributes_list was already not a valid
Simulator option.