Serialize winword identify#49
Merged
Merged
Conversation
Concurrent diffword launches (eg Verify reporting several failed snapshots from one test run) snapshot overlapping PID sets and can claim the same, or each other's, WINWORD. A misidentified WINWORD is assigned to the wrong Job Object (or none), so killing its diffword (eg DiffEngineTray accept) leaves it running as an invisible zombie holding locks on the compared files. - Extract the snapshot-create-identify-assign sequence into CreateWordInJob, serialized across processes with a temp file lock (same pattern as diffexcel's SpreadsheetCompare) - Quit/kill the just-created instance when identification or assignment fails instead of leaking it - Log the assigned WINWORD pid and exit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.