fix: align auth login nonce and token expiry#109
Merged
nonsobethel0-dev merged 1 commit intoJun 27, 2026
Merged
Conversation
|
@charlesedeh021-cell Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes two assigned authentication issues in the wallet login flow.
Changes
JwtServicethroughexpiresIn.AuthController.login()to return the expiry fromJwtServiceinstead of hardcoding'7d'.expiresInmatches the value exposed byJwtService.Closes #91
Closes #92
Closes #89
Closes #90
Notes
The nonce is still deleted for expired challenges, but it is no longer deleted before signature verification. This preserves the one-time-use behavior for successful login while avoiding accidental or malicious challenge consumption on failed verification.
The JWT expiry remains
7d, but it now has a single source inJwtService, so future expiry changes will automatically be reflected in the login response.Testing
Not run, per request.
I only ran
git diff --check.