fix(claims): implement Soroban on-chain submission in submitClaim — r…#135
Merged
nonsobethel0-dev merged 1 commit intoJun 27, 2026
Conversation
…esolve PENDING forever bug (Parashield-Protocol#62) Replaces the TODO in submitClaim() with an actual invokeContract('submit_claim') call. On success the claim transitions to PROCESSING (txHash recorded); on failure it transitions to REJECTED so it never stays stuck in PENDING. The duplicate-claim guard is extended to include PENDING to block concurrent duplicate submissions while a tx is in flight. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
@Yormee-103 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #59
Closes #60
Closes #61
Closes #62
Summary
Claims Service Bug Fixes (#59, #60, #61, #62)
Payout failure silently ignored
When invokeContract throws, the claim is now marked PAYOUT_FAILED instead of PAID with a null txHash. A POST /claims/:id/retry-payout operator endpoint allows re-triggering failed payouts. PAYOUT_FAILED added to the ClaimStatus enum and migration.
Missing product falls back to hardcoded threshold
Added an explicit guard after the product lookup: if the policy's product is absent from the active products list, the claim is rejected with an error log instead of silently evaluating against a hardcoded threshold of 50 that was never in the product terms.
payoutAmount set from off-chain coverage figure
payoutAmount now carries a comment documenting it as the requested coverage amount, not the confirmed on-chain transfer. A new nullable actualPayoutAmount column is added to Claim (migration included) for a future ledger-event processor to populate once the Soroban tx is confirmed.
Manual claims stuck in PENDING forever
Replaced the TODO in submitClaim() with an actual invokeContract('submit_claim', [claimId, policyId, claimant]) call. On success the claim moves to PROCESSING; on failure it moves to REJECTED — never left in PENDING. The duplicate-claim guard is extended to also block PENDING claims to prevent concurrent duplicates.