Fix Sonar findings

.github/workflows/dependabot_automerge.yml

@@ -12,7 +12,7 @@ jobs:
     steps:
       - name: Dependabot metadata
         id: metadata
-        uses: dependabot/fetch-metadata@v2.5.0
+        uses: dependabot/fetch-metadata@v3.1.0
         with:
           github-token: "${{ secrets.GITHUB_TOKEN }}"
       - name: Enable auto-merge for Dependabot PRs

.github/workflows/main_pathfinderhonormanager.yml

@@ -23,7 +23,7 @@ jobs:
       - name: Test with the dotnet CLI (OpenCover)
         run: dotnet test PathfinderHonorManager.Tests/PathfinderHonorManager.Tests.csproj /p:CollectCoverage=true /p:CoverletOutput=TestResults/coverage.opencover.xml /p:CoverletOutputFormat=opencover /p:Exclude="[PathfinderHonorManager.Tests*]*"
       - name: Upload coverage report
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v7
         with:
           name: coverage-report
           path: PathfinderHonorManager.Tests/TestResults/coverage.opencover.xml
@@ -38,7 +38,7 @@ jobs:
           fetch-depth: 0
       - uses: ./.github/actions/setup-dotnet
       - name: Download coverage report
-        uses: actions/download-artifact@v7
+        uses: actions/download-artifact@v8
         with:
           name: coverage-report
           path: .
@@ -91,7 +91,7 @@ jobs:
         working-directory: ./PathfinderHonorManager
 
       - name: Upload Migration Script
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v7
         with:
           name: migration-script
           path: PathfinderHonorManager/migration.sql
@@ -109,7 +109,7 @@ jobs:
           App.ServerRootAddress: ${{ env.SERVER_ROOT_ADDRESS }}
 
       - name: Upload artifact for deployment job
-        uses: actions/upload-artifact@v6
+        uses: actions/upload-artifact@v7
         with:
           name: .net-app
           path: ${{env.DOTNET_ROOT}}/myapp
@@ -124,7 +124,7 @@ jobs:
 
     steps:
       - name: Download artifact from build job
-        uses: actions/download-artifact@v7
+        uses: actions/download-artifact@v8
         with:
           name: .net-app
 

.gitignore

@@ -251,8 +251,9 @@ _TeamCity*
 *.coverage
 *.coveragexml
 
-# Coverlet code coverage results
-coverage.json
+# Coverlet code coverage results
+coverage.json
+coverage.opencover.xml
 
 # NCrunch
 _NCrunch_*
@@ -448,4 +449,4 @@ ASALocalRun/
 .mfractor/
 
 # Local History for Visual Studio
-.localhistory/
+.localhistory/

AGENTS.md

@@ -3,7 +3,6 @@
 ## Project Structure & Module Organization
 - `PathfinderHonorManager/` hosts the ASP.NET Core API. Key areas: `Controllers/`, `Service/`, `DataAccess/`, `Model/`, `Dto/`, `Validators/`, `Healthcheck/`, `Migrations/`, `Swagger/`, `Mapping/`, and `Converters/`.
 - `PathfinderHonorManager.Tests/` contains NUnit tests plus test helpers and seeders.
-- `PathfinderHonorManager/Pathfinder-DB/` stores database SQL scripts.
 - Configuration lives in `PathfinderHonorManager/appsettings.json`, `PathfinderHonorManager/appsettings.Development.json`, and `PathfinderHonorManager/Properties/launchSettings.json`.
 
 ## Build, Test, and Development Commands

PathfinderHonorManager.Tests/Controllers/PathfindersControllerTests.cs

@@ -345,6 +345,162 @@ public async Task BulkPut_WithValidData_ReturnsMultiStatus()
             Assert.That(multiStatusResult.StatusCode, Is.EqualTo(207));
         }
 
+        [Test]
+        public async Task BulkPut_WithValidItem_ReturnsOkStatusPerItem()
+        {
+            var pathfinderId = Guid.NewGuid();
+            var bulkData = new List<Incoming.BulkPutPathfinderDto>
+            {
+                new Incoming.BulkPutPathfinderDto
+                {
+                    Items = new List<Incoming.BulkPutPathfinderItemDto>
+                    {
+                        new Incoming.BulkPutPathfinderItemDto
+                        {
+                            PathfinderId = pathfinderId,
+                            Grade = 6,
+                            IsActive = true
+                        }
+                    }
+                }
+            };
+
+            var updatedPathfinder = new Outgoing.PathfinderDto
+            {
+                PathfinderID = pathfinderId,
+                FirstName = "Test",
+                LastName = "User",
+                Grade = 6,
+                IsActive = true
+            };
+
+            _pathfinderServiceMock
+                .Setup(x => x.UpdateAsync(pathfinderId, It.IsAny<Incoming.PutPathfinderDto>(), TestClubCode, It.IsAny<CancellationToken>()))
+                .ReturnsAsync(updatedPathfinder);
+
+            var result = await _controller.BulkPutPathfindersAsync(bulkData, new CancellationToken());
+
+            Assert.That(result, Is.Not.Null);
+            var multiStatusResult = result as ObjectResult;
+            Assert.That(multiStatusResult.StatusCode, Is.EqualTo(207));
+            var responses = ((IEnumerable<object>)multiStatusResult.Value).ToList();
+            Assert.That(responses.Count, Is.EqualTo(1));
+            Assert.That(GetAnonymousProperty<int>(responses[0], "status"), Is.EqualTo(StatusCodes.Status200OK));
+        }
+
+        [Test]
+        public async Task BulkPut_WithMissingPathfinder_ReturnsNotFoundStatusPerItem()
+        {
+            var pathfinderId = Guid.NewGuid();
+            var bulkData = new List<Incoming.BulkPutPathfinderDto>
+            {
+                new Incoming.BulkPutPathfinderDto
+                {
+                    Items = new List<Incoming.BulkPutPathfinderItemDto>
+                    {
+                        new Incoming.BulkPutPathfinderItemDto
+                        {
+                            PathfinderId = pathfinderId,
+                            Grade = 6,
+                            IsActive = true
+                        }
+                    }
+                }
+            };
+
+            _pathfinderServiceMock
+                .Setup(x => x.UpdateAsync(pathfinderId, It.IsAny<Incoming.PutPathfinderDto>(), TestClubCode, It.IsAny<CancellationToken>()))
+                .ReturnsAsync((Outgoing.PathfinderDto)null);
+
+            var result = await _controller.BulkPutPathfindersAsync(bulkData, new CancellationToken());
+
+            Assert.That(result, Is.Not.Null);
+            var multiStatusResult = result as ObjectResult;
+            Assert.That(multiStatusResult.StatusCode, Is.EqualTo(207));
+            var responses = ((IEnumerable<object>)multiStatusResult.Value).ToList();
+            Assert.That(responses.Count, Is.EqualTo(1));
+            Assert.That(GetAnonymousProperty<int>(responses[0], "status"), Is.EqualTo(StatusCodes.Status404NotFound));
+        }
+
+        [Test]
+        public async Task BulkPut_WithValidationError_ReturnsBadRequestStatusPerItem()
+        {
+            var pathfinderId = Guid.NewGuid();
+            var bulkData = new List<Incoming.BulkPutPathfinderDto>
+            {
+                new Incoming.BulkPutPathfinderDto
+                {
+                    Items = new List<Incoming.BulkPutPathfinderItemDto>
+                    {
+                        new Incoming.BulkPutPathfinderItemDto
+                        {
+                            PathfinderId = pathfinderId,
+                            Grade = 15,
+                            IsActive = true
+                        }
+                    }
+                }
+            };
+
+            var validationErrors = new List<FluentValidation.Results.ValidationFailure>
+            {
+                new FluentValidation.Results.ValidationFailure("Grade", "Grade must be between 5 and 12.")
+            };
+            var validationException = new ValidationException(validationErrors);
+
+            _pathfinderServiceMock
+                .Setup(x => x.UpdateAsync(pathfinderId, It.IsAny<Incoming.PutPathfinderDto>(), TestClubCode, It.IsAny<CancellationToken>()))
+                .ThrowsAsync(validationException);
+
+            var result = await _controller.BulkPutPathfindersAsync(bulkData, new CancellationToken());
+
+            Assert.That(result, Is.Not.Null);
+            var multiStatusResult = result as ObjectResult;
+            Assert.That(multiStatusResult.StatusCode, Is.EqualTo(207));
+            var responses = ((IEnumerable<object>)multiStatusResult.Value).ToList();
+            Assert.That(responses.Count, Is.EqualTo(1));
+            Assert.That(GetAnonymousProperty<int>(responses[0], "status"), Is.EqualTo(StatusCodes.Status400BadRequest));
+        }
+
+        [Test]
+        public async Task BulkPut_WithDatabaseError_ReturnsBadRequestStatusPerItem()
+        {
+            var pathfinderId = Guid.NewGuid();
+            var bulkData = new List<Incoming.BulkPutPathfinderDto>
+            {
+                new Incoming.BulkPutPathfinderDto
+                {
+                    Items = new List<Incoming.BulkPutPathfinderItemDto>
+                    {
+                        new Incoming.BulkPutPathfinderItemDto
+                        {
+                            PathfinderId = pathfinderId,
+                            Grade = 6,
+                            IsActive = true
+                        }
+                    }
+                }
+            };
+
+            _pathfinderServiceMock
+                .Setup(x => x.UpdateAsync(pathfinderId, It.IsAny<Incoming.PutPathfinderDto>(), TestClubCode, It.IsAny<CancellationToken>()))
+                .ThrowsAsync(new DbUpdateException("Database error"));
+
+            var result = await _controller.BulkPutPathfindersAsync(bulkData, new CancellationToken());
+
+            Assert.That(result, Is.Not.Null);
+            var multiStatusResult = result as ObjectResult;
+            Assert.That(multiStatusResult.StatusCode, Is.EqualTo(207));
+            var responses = ((IEnumerable<object>)multiStatusResult.Value).ToList();
+            Assert.That(responses.Count, Is.EqualTo(1));
+            Assert.That(GetAnonymousProperty<int>(responses[0], "status"), Is.EqualTo(StatusCodes.Status400BadRequest));
+        }
+
+        private static T GetAnonymousProperty<T>(object instance, string propertyName)
+        {
+            return (T)instance.GetType().GetProperty(propertyName)!.GetValue(instance);
+        }
+
         [TearDown]
         public async Task TearDown()
         {
@@ -358,4 +514,4 @@ public async Task OneTimeTearDown()
             await _dbContext.DisposeAsync();
         }
     }
-} 
+} 

PathfinderHonorManager.Tests/Integration/TestAuthHandler.cs

@@ -35,8 +35,11 @@ public TestAuthHandler(
             IOptionsMonitor<TestAuthOptions> options,
             ILoggerFactory logger,
             UrlEncoder encoder,
+            // TODO: Switch to TimeProvider when AuthenticationHandler supports it for this target framework.
+#pragma warning disable CS0618
             ISystemClock clock)
             : base(options, logger, encoder, clock)
+#pragma warning restore CS0618
         {
         }
 

PathfinderHonorManager.Tests/PathfinderHonorManager.Tests.csproj

@@ -9,23 +9,24 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="coverlet.msbuild" Version="6.0.4">
+    <PackageReference Include="coverlet.msbuild" Version="10.0.1">
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>
     <PackageReference Include="FluentValidation" Version="12.1.1" />
+    <PackageReference Include="Microsoft.Extensions.Diagnostics.HealthChecks" Version="10.0.8" />
     <PackageReference Include="Moq" Version="4.20.72" />
-    <PackageReference Include="NUnit" Version="4.4.0" />
-    <PackageReference Include="NUnit3TestAdapter" Version="6.1.0" />
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
-    <PackageReference Include="Microsoft.Data.Sqlite.Core" Version="10.0.1" />
-    <PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite" Version="10.0.1" />
-    <PackageReference Include="FluentValidation.Validators.UnitTestExtension" Version="1.12.0.2" />
+    <PackageReference Include="NUnit" Version="4.6.1" />
+    <PackageReference Include="NUnit3TestAdapter" Version="6.2.0" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.6.0" />
+    <PackageReference Include="Microsoft.Data.Sqlite.Core" Version="10.0.8" />
+    <PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite" Version="10.0.8" />
+    <PackageReference Include="FluentValidation.Validators.UnitTestExtension" Version="1.12.0.5" />
     <PackageReference Include="FluentValidation.DependencyInjectionExtensions" Version="12.1.1" />
-    <PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="10.0.1" />
-    <PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="10.0.1" />
-    <PackageReference Include="Npgsql.EntityFrameworkCore.PostgreSQL" Version="10.0.0" />
-    <PackageReference Include="Microsoft.Extensions.Diagnostics.HealthChecks.EntityFrameworkCore" Version="10.0.1" />
+    <PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="10.0.8" />
+    <PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="10.0.8" />
+    <PackageReference Include="Npgsql.EntityFrameworkCore.PostgreSQL" Version="10.0.2" />
+    <PackageReference Include="Microsoft.Extensions.Diagnostics.HealthChecks.EntityFrameworkCore" Version="10.0.8" />
   </ItemGroup>
 
   <ItemGroup>

PathfinderHonorManager.Tests/Service/MigrationServiceTests.cs

@@ -30,7 +30,7 @@ public void StartAsync_MissingConnectionString_Throws()
         }
 
         [Test]
-        public async Task StopAsync_ReturnsCompletedTask()
+        public void StopAsync_ReturnsCompletedTask()
         {
             var services = new ServiceCollection().BuildServiceProvider();
             var configuration = new ConfigurationBuilder()
@@ -39,7 +39,28 @@ public async Task StopAsync_ReturnsCompletedTask()
             var logger = NullLogger<MigrationService>.Instance;
             var service = new MigrationService(services, logger, configuration);
 
-            await service.StopAsync(CancellationToken.None);
+            Assert.DoesNotThrowAsync(() => service.StopAsync(CancellationToken.None));
+        }
+
+        [Test]
+        public void StartAsync_InvalidDatabaseConnection_ThrowsWrappedInvalidOperationException()
+        {
+            var services = new ServiceCollection().BuildServiceProvider();
+            var configuration = new ConfigurationBuilder()
+                .AddInMemoryCollection(new Dictionary<string, string>
+                {
+                    ["ConnectionStrings:PathfinderMigrationCS"] =
+                        "Host=127.0.0.1;Port=1;Database=testdb;Username=test;Password=test;Timeout=1;Command Timeout=1"
+                })
+                .Build();
+            var logger = NullLogger<MigrationService>.Instance;
+            var service = new MigrationService(services, logger, configuration);
+
+            var ex = Assert.ThrowsAsync<InvalidOperationException>(
+                () => service.StartAsync(CancellationToken.None));
+
+            Assert.That(ex!.Message, Does.Contain("Database migration failed during application startup"));
+            Assert.That(ex.InnerException, Is.Not.Null);
         }
     }
 }