feat: add Stellar address validation for authorAddress (#605)#626
Merged
BigBen-7 merged 2 commits intoJun 23, 2026
Merged
Conversation
- Create IsStellarAddress custom class-validator decorator - Uses StrKey.isValidEd25519PublicKey() from @stellar/stellar-sdk - Apply @IsStellarAddress() to authorAddress in CreateGistDto - Export decorator from common/validators index - Add unit tests covering valid, invalid, absent, and empty cases Closes PinSpace-Org#605
Tinna23
approved these changes
Jun 22, 2026
Contributor
|
@BashMan11 please resolve conflicts |
BigBen-7
approved these changes
Jun 23, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a custom
@IsStellarAddress()class-validator decorator that validates Stellar Ed25519 public keys using the official@stellar/stellar-sdkStrKey.isValidEd25519PublicKey()method, and applies it toauthorAddressinCreateGistDto.Changes
Backend/src/common/validators/stellar-address.validator.ts— custom decoratorBackend/src/common/validators/index.ts— re-exports the decoratorBackend/src/gists/dto/create-gist.dto.ts— applies@IsStellarAddress()toauthorAddressBackend/src/common/validators/stellar-address.validator.spec.ts— unit testsTest Results
All 5 unit tests pass:
Closes #605