-
Notifications
You must be signed in to change notification settings - Fork 18
Submission - wilson-romero #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wilson-romero
wants to merge
9
commits into
PlatziMaster:master
Choose a base branch
from
wilson-romero:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0baf4cc
[solution] challenge python 9
wilson-romero 6990d46
[correction] challenge python 9
wilson-romero 2623664
[correction] challenge python 9
wilson-romero edf934c
New submission - wilson-romero
wilson-romero f726f1a
New submission - wilson-romero
wilson-romero 83259b8
Fix solution with zeros null or full zeros
wilson-romero 84e4421
fix solution
wilson-romero 187291f
remove comments
wilson-romero b6400bf
fix pylint errors
wilson-romero File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| """ Module solution """ | ||
| from typing import List | ||
|
|
||
| class Solution: | ||
| """ Challenge solution """ | ||
| def duplicate_zeros(self, arr: List[int]): | ||
| """Duplicate zeros and shift right""" | ||
| next_index = 0 | ||
| length = len(arr) | ||
| while True: | ||
| try: | ||
| next_index = arr.index(0, next_index) | ||
| arr.insert(next_index + 1, 0) | ||
| arr.pop() | ||
| next_index = next_index + 2 | ||
| except ValueError: | ||
| break | ||
| arr = arr[:length] | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Watch out with this operation. Your solution isn't optimum, its O(n^2) in time and O(n) in space. There's a O(n) in time and O(1) in space solution.