fix(deps): downgrade php-humanizer and structure-discoverer for PHP 8…#256
Closed
lhall-amphibee wants to merge 1 commit intoPollora:developfrom
Closed
fix(deps): downgrade php-humanizer and structure-discoverer for PHP 8…#256lhall-amphibee wants to merge 1 commit intoPollora:developfrom
lhall-amphibee wants to merge 1 commit intoPollora:developfrom
Conversation
….2 compat coduo/php-humanizer 5.x requires PHP ~8.3, pinning to ^4.0 restores 8.2 support. spatie/php-structure-discoverer dev-main requires PHP ^8.3, ^2.0 is 8.1+ compatible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
developbranch currently pulls in packages that are incompatible with PHP 8.2:coduo/php-humanizer 5.0.3— requires PHP~8.3 || ~8.4spatie/php-structure-discoverer dev-main— requires PHP^8.3This causes
composer installto fail on any environment running PHP 8.2 (e.g. production servers locked to 8.2).Fix
coduo/php-humanizer:5.0.3→^4.0(PHP 8.1+ compatible, sameStringHumanizer::humanize()API)spatie/php-structure-discoverer:dev-main→^2.0(PHP 8.1+ compatible, sameDiscover/DiscoveredClass/cache driver API)Notes
The declared PHP constraint in
composer.jsonis^8.2.0, so these pinned packages were inconsistent with that constraint.