Skip to content

Fixed remaining red tests#333

Merged
jordanmontt merged 5 commits intoPolyMathOrg:masterfrom
DurieuxPol:fix/redTests
Mar 27, 2026
Merged

Fixed remaining red tests#333
jordanmontt merged 5 commits intoPolyMathOrg:masterfrom
DurieuxPol:fix/redTests

Conversation

@DurieuxPol
Copy link
Copy Markdown
Contributor

Several testPrint tests of FunctionFit were broken because the way BlockClosure are printed as strings changed in recent Pharo versions, so I adapted the code around it.
Also, the way Random is initialised with seed has changed as well in recent Pharo versions, so I changed the seed in the setup of PMClusterFinderTest so that the tests are green in all versions.

@DurieuxPol
Copy link
Copy Markdown
Contributor Author

DurieuxPol commented Mar 26, 2026

The last red test is PMQRTest>>testDecompositionOfMatrixCausingErraticFailure mentioned also in issue 10 of vector-matrix. I think it needs more work to solve the issue, so I will do another PR for that.
So this one is good to merge !

@jordanmontt jordanmontt merged commit d3193c0 into PolyMathOrg:master Mar 27, 2026
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants