Port:OC alpha.191+26.1,1.21.11,1.21.5+Feat:FadeOut#12
Merged
Conversation
Wyvest
requested changes
Jun 6, 2026
| OmniImage newImage = OmniImages.from(image); | ||
| DamageTintClient.INSTANCE.LOGGER.info("updateOverlayColor called in mixin"); | ||
| boolean isARGB = true; | ||
| Method setPixelMethod = null; |
Member
There was a problem hiding this comment.
Please use a mixin invoker instead
Member
There was a problem hiding this comment.
Wait bruh just use Stonecutter preprocessing why did you even do reflection
Author
|
Wyvest
requested changes
Jun 6, 2026
| } | ||
| }) | ||
| } else { | ||
| findProperty("yarn_mappings")?.toString()?.takeUnless { it.isBlank() }?.let { |
Member
There was a problem hiding this comment.
remove this part (we dont do yarn mappings anymore, we dont support anything except mojang mappings)
| // fabric-loader 0.18.4 bundles sponge-mixin 0.17.0, which lacks IAdviceProvider. | ||
| // OneConfig alpha.191 was compiled against 0.17.2 which added that class. | ||
| // Force the newer version to avoid NoClassDefFoundError at runtime. | ||
| force("net.fabricmc:sponge-mixin:0.17.2+mixin.0.8.7") |
Author
There was a problem hiding this comment.
uhm i forgot to review what it did to fix that error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bring to OneConfig v1 alpha.191
Add support for versions:
Re-implement feature: Tint fade out