Add corrected viscoelastic data#87
Open
mikemccabe210 wants to merge 4 commits into
Open
Conversation
Member
|
I'm on it! |
Member
|
@mikemccabe210 it seems I don't have access, can you make it r+x for me? |
Contributor
Author
|
@MilesCranmer Oops. My bad. Fixed the permissions. |
Member
|
@mikemccabe210 ok i think i finished the transfer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #74 . thanks to @beneitez for finding the error in the processing code and fixing it. This PR mostly just fixes the paths to point to the fixed data. It looks like a big PR, but most of these changes are just documentation which is copied from the old data with deprecation notices added to either side.
Changes:
The transformation code is in a notebook (/mnt/home/polymathic/ceph/the_well/testing_before_adding/viscov2/viscoelastic_transformation.ipynb) and copied @rubenohana's original code and added some transposes to match the current convention (dim order = x, y).
Note: the data itself is currently on rusty - all download paths are pointing popeye, so you'll need to sync that over. It doesn't look like I have permission to do that anymore. @payelmuk150 @MilesCranmer . Since the full pipeline hasn't been tested, I'd recommend transferring the data, testing out the download script and making sure the new paths work before merging.