Skip to content

Db v4 move graph folder#2624

Open
arienandalibi wants to merge 6 commits into
db_v4from
db_v4_move_graph_folder
Open

Db v4 move graph folder#2624
arienandalibi wants to merge 6 commits into
db_v4from
db_v4_move_graph_folder

Conversation

@arienandalibi

Copy link
Copy Markdown
Collaborator

What changes were proposed in this pull request?

Move graph_folder.rs constants (directory and file names regarding exported graphs) out of the raphtory crate and into raphtory-api.

Why are the changes needed?

Following previous changes, we needed access to GRAPH_META_PATH in pometry-storage, where we can't import from raphtory.

Does this PR introduce any user-facing change? If yes is this documented?

No

How was this patch tested?

Tests still pass

Are there any further changes required?

No

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: adede86 Previous: 9823ef7 Ratio
lotr_graph/num_edges 4 ns/iter (± 0) 0 ns/iter (± 0) +∞
lotr_graph/num_nodes 4 ns/iter (± 0) 1 ns/iter (± 0) 4
lotr_graph/graph_latest 3 ns/iter (± 0) 0 ns/iter (± 0) +∞
lotr_graph_materialise/materialize 8051392 ns/iter (± 53457) 1564816 ns/iter (± 35303) 5.15
lotr_graph_window_100/num_nodes 13 ns/iter (± 0) 5 ns/iter (± 0) 2.60
lotr_graph_window_100_materialise/materialize 8139728 ns/iter (± 83432) 1669150 ns/iter (± 10700) 4.88
lotr_graph_window_10/has_node_existing 137 ns/iter (± 10) 62 ns/iter (± 11) 2.21
lotr_graph_window_10/iterate nodes 28561 ns/iter (± 335) 11339 ns/iter (± 40) 2.52
lotr_graph_window_10_materialise/materialize 3311386 ns/iter (± 28932) 971980 ns/iter (± 4278) 3.41
lotr_graph_subgraph_10pc/has_node_nonexisting 5 ns/iter (± 0) 2 ns/iter (± 0) 2.50
lotr_graph_subgraph_10pc_materialise/materialize 2071907 ns/iter (± 21757) 334634 ns/iter (± 1287) 6.19
lotr_graph_subgraph_10pc_windowed/has_node_existing 141 ns/iter (± 8) 62 ns/iter (± 14) 2.27
lotr_graph_subgraph_10pc_windowed/iterate nodes 4865 ns/iter (± 102) 1365 ns/iter (± 3) 3.56
lotr_graph_subgraph_10pc_windowed_materialise/materialize 1246015 ns/iter (± 12404) 230399 ns/iter (± 2617) 5.41
lotr_graph_window_50_layered/num_edges_temporal 147011 ns/iter (± 3487) 70121 ns/iter (± 7586) 2.10
lotr_graph_window_50_layered/has_node_existing 401 ns/iter (± 28) 129 ns/iter (± 12) 3.11
lotr_graph_window_50_layered/iterate nodes 66622 ns/iter (± 2391) 19308 ns/iter (± 47) 3.45
lotr_graph_window_50_layered/iterate edges 171448 ns/iter (± 1699) 83616 ns/iter (± 1318) 2.05
lotr_graph_window_50_layered/graph_latest 85838 ns/iter (± 2089) 36649 ns/iter (± 916) 2.34
lotr_graph_window_50_layered_materialise/materialize 29233032 ns/iter (± 151361) 3488825 ns/iter (± 24948) 8.38
lotr_graph_persistent_window_50_layered/num_edges_temporal 599618 ns/iter (± 5305) 192686 ns/iter (± 1569) 3.11
lotr_graph_persistent_window_50_layered/has_node_existing 416 ns/iter (± 370) 174 ns/iter (± 83) 2.39
lotr_graph_persistent_window_50_layered/iterate nodes 96990 ns/iter (± 838) 35886 ns/iter (± 191) 2.70
lotr_graph_persistent_window_50_layered/graph_latest 128257 ns/iter (± 1443) 57549 ns/iter (± 4809) 2.23
lotr_graph_persistent_window_50_layered_materialise/materialize 49765367 ns/iter (± 183761) 5298035 ns/iter (± 147912) 9.39

This comment was automatically generated by workflow using github-action-benchmark.

@arienandalibi arienandalibi marked this pull request as ready for review June 10, 2026 06:30
@@ -25,29 +31,6 @@ use std::{
use walkdir::WalkDir;
use zip::{write::FileOptions, ZipArchive, ZipWriter};

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just move this entire file to raphtory-api, then you can just call the method in here to update the metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants