Skip to content

make sure the optimisation flags for cached view are set correctly#2645

Open
ljeub-pometry wants to merge 8 commits into
db_v4from
fix_cached_view_optimisation
Open

make sure the optimisation flags for cached view are set correctly#2645
ljeub-pometry wants to merge 8 commits into
db_v4from
fix_cached_view_optimisation

Conversation

@ljeub-pometry

Copy link
Copy Markdown
Collaborator

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change? If yes is this documented?

How was this patch tested?

Are there any further changes required?

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 65b0a97 Previous: 9823ef7 Ratio
large/1k random edge additions 1472727 ns/iter (± 43349) 658628 ns/iter (± 51943) 2.24
large/1k random edge additions with numeric string input 2124667 ns/iter (± 97152) 876236 ns/iter (± 86855) 2.42
lotr_graph/num_edges 3 ns/iter (± 0) 0 ns/iter (± 0) +∞
lotr_graph/num_nodes 3 ns/iter (± 0) 1 ns/iter (± 0) 3
lotr_graph/graph_latest 2 ns/iter (± 0) 0 ns/iter (± 0) +∞
lotr_graph_materialise/materialize 8369117 ns/iter (± 56599) 1564816 ns/iter (± 35303) 5.35
lotr_graph_window_100/num_nodes 13 ns/iter (± 0) 5 ns/iter (± 0) 2.60
lotr_graph_window_100_materialise/materialize 7903828 ns/iter (± 72139) 1669150 ns/iter (± 10700) 4.74
lotr_graph_window_10_materialise/materialize 3113509 ns/iter (± 29124) 971980 ns/iter (± 4278) 3.20
lotr_graph_subgraph_10pc/num_nodes 12 ns/iter (± 0) 4 ns/iter (± 0) 3
lotr_graph_subgraph_10pc_materialise/materialize 1944419 ns/iter (± 50142) 334634 ns/iter (± 1287) 5.81
lotr_graph_subgraph_10pc_windowed/has_node_existing 128 ns/iter (± 10) 62 ns/iter (± 14) 2.06
lotr_graph_subgraph_10pc_windowed_materialise/materialize 1100759 ns/iter (± 17556) 230399 ns/iter (± 2617) 4.78
lotr_graph_window_50_layered/has_node_existing 352 ns/iter (± 21) 129 ns/iter (± 12) 2.73
lotr_graph_window_50_layered/graph_latest 86843 ns/iter (± 2212) 36649 ns/iter (± 916) 2.37
lotr_graph_window_50_layered_materialise/materialize 27951581 ns/iter (± 371519) 3488825 ns/iter (± 24948) 8.01
lotr_graph_persistent_window_50_layered/num_edges_temporal 632827 ns/iter (± 9398) 192686 ns/iter (± 1569) 3.28
lotr_graph_persistent_window_50_layered/has_node_existing 390 ns/iter (± 327) 174 ns/iter (± 83) 2.24
lotr_graph_persistent_window_50_layered/graph_latest 128584 ns/iter (± 2235) 57549 ns/iter (± 4809) 2.23
lotr_graph_persistent_window_50_layered_materialise/materialize 44713174 ns/iter (± 957698) 5298035 ns/iter (± 147912) 8.44

This comment was automatically generated by workflow using github-action-benchmark.

@fabianmurariu fabianmurariu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants