Skip to content

Db v4 group tests#2647

Draft
arienandalibi wants to merge 7 commits into
db_v4from
db_v4_group_tests
Draft

Db v4 group tests#2647
arienandalibi wants to merge 7 commits into
db_v4from
db_v4_group_tests

Conversation

@arienandalibi

Copy link
Copy Markdown
Collaborator

What changes were proposed in this pull request?

Group test files based on test contents. By grouping them into folders, we make multiple test files compile into a single "crate" (binary). This saves us time when building because, for each single test file not in a folder, a whole binary is built, and this binary needs to link all of raphtory and its associated crates. By limiting the number of binaries, we also limit this overhead.

Why are the changes needed?

Faster build times

Does this PR introduce any user-facing change? If yes is this documented?

No

How was this patch tested?

All the tests are still run and still pass

Are there any further changes required?

No

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: e706f2f Previous: 9823ef7 Ratio
large/1k random edge additions 1476082 ns/iter (± 140334) 658628 ns/iter (± 51943) 2.24
large/1k random edge additions with numeric string input 1982823 ns/iter (± 150760) 876236 ns/iter (± 86855) 2.26
lotr_graph/num_edges 3 ns/iter (± 0) 0 ns/iter (± 0) +∞
lotr_graph/num_nodes 3 ns/iter (± 0) 1 ns/iter (± 0) 3
lotr_graph/graph_latest 2 ns/iter (± 0) 0 ns/iter (± 0) +∞
lotr_graph_materialise/materialize 7853566 ns/iter (± 55529) 1564816 ns/iter (± 35303) 5.02
lotr_graph_window_100/num_nodes 13 ns/iter (± 0) 5 ns/iter (± 0) 2.60
lotr_graph_window_100_materialise/materialize 8067230 ns/iter (± 42102) 1669150 ns/iter (± 10700) 4.83
lotr_graph_window_10/has_node_existing 129 ns/iter (± 10) 62 ns/iter (± 11) 2.08
lotr_graph_window_10/iterate nodes 24921 ns/iter (± 205) 11339 ns/iter (± 40) 2.20
lotr_graph_window_10_materialise/materialize 3109632 ns/iter (± 10460) 971980 ns/iter (± 4278) 3.20
lotr_graph_subgraph_10pc/num_nodes 16 ns/iter (± 1) 4 ns/iter (± 0) 4
lotr_graph_subgraph_10pc_materialise/materialize 1990591 ns/iter (± 18731) 334634 ns/iter (± 1287) 5.95
lotr_graph_subgraph_10pc_windowed/has_node_existing 130 ns/iter (± 11) 62 ns/iter (± 14) 2.10
lotr_graph_subgraph_10pc_windowed/iterate nodes 4268 ns/iter (± 112) 1365 ns/iter (± 3) 3.13
lotr_graph_subgraph_10pc_windowed_materialise/materialize 1095867 ns/iter (± 12011) 230399 ns/iter (± 2617) 4.76
lotr_graph_window_50_layered/num_edges_temporal 141199 ns/iter (± 1766) 70121 ns/iter (± 7586) 2.01
lotr_graph_window_50_layered/has_node_existing 323 ns/iter (± 18) 129 ns/iter (± 12) 2.50
lotr_graph_window_50_layered/iterate nodes 55967 ns/iter (± 322) 19308 ns/iter (± 47) 2.90
lotr_graph_window_50_layered/graph_latest 82571 ns/iter (± 3868) 36649 ns/iter (± 916) 2.25
lotr_graph_window_50_layered_materialise/materialize 26952703 ns/iter (± 515099) 3488825 ns/iter (± 24948) 7.73
lotr_graph_persistent_window_50_layered/num_edges_temporal 630719 ns/iter (± 7211) 192686 ns/iter (± 1569) 3.27
lotr_graph_persistent_window_50_layered/has_node_existing 368 ns/iter (± 317) 174 ns/iter (± 83) 2.11
lotr_graph_persistent_window_50_layered/iterate nodes 83489 ns/iter (± 496) 35886 ns/iter (± 191) 2.33
lotr_graph_persistent_window_50_layered/graph_latest 137925 ns/iter (± 2055) 57549 ns/iter (± 4809) 2.40
lotr_graph_persistent_window_50_layered_materialise/materialize 45135943 ns/iter (± 355820) 5298035 ns/iter (± 147912) 8.52

This comment was automatically generated by workflow using github-action-benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant