feat(code): inbox onboarding takeover + Agents callout#2567
Open
Twixes wants to merge 2 commits into
Open
Conversation
|
React Doctor found 7 issues in 2 files · 7 warnings. 7 warnings
Reviewed by React Doctor for commit |
Contributor
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
apps/code/src/renderer/features/inbox/components/onboarding/useInboxOnboardingState.ts:63-77
`isLoading` only covers `teamConfigLoading || sourcesLoading`, but `useIntegrationSelectors` reads from a zustand store that starts empty (`integrations: []`) and is populated asynchronously by `useIntegrations()`. Until that fetch resolves, `hasSlackIntegration` and `hasGithubIntegration` are both `false`, so `isComplete` computes as `false` before any integrations have loaded. Meanwhile, `isLoading` is already `false` if team-config and sources fetches finished first, meaning `showOnboarding = true` in `InboxView` and the welcome takeover flashes for fully-onboarded users on every page load. `useRepositoryIntegration` already exposes `isLoadingRepos` (= `integrationsPending || reposPending`) — including it covers both the integration-list and repos loading windows.
```suggestion
const {
hasGithubIntegration,
repositories,
isLoadingRepos,
} = useRepositoryIntegration();
const { data: teamConfig, isLoading: teamConfigLoading } =
useSignalTeamConfig();
const { displayValues, isLoading: sourcesLoading } = useSignalSourceToggles();
const slackSkipped = useInboxOnboardingSessionStore((s) => s.slackSkipped);
const slackDone = hasSlackIntegration || slackSkipped;
const githubDone = hasGithubIntegration && repositories.length > 0;
const sourcesDone = Object.values(displayValues).some(Boolean);
const notificationsApplicable = hasSlackIntegration && !slackSkipped;
const notificationsDone =
!notificationsApplicable ||
!!teamConfig?.default_slack_notification_channel;
const isLoading = teamConfigLoading || sourcesLoading || isLoadingRepos;
```
Reviews (1): Last reviewed commit: "fix(code): onboarding welcome – PR-first..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+63
to
+77
| const { hasGithubIntegration, repositories } = useRepositoryIntegration(); | ||
| const { data: teamConfig, isLoading: teamConfigLoading } = | ||
| useSignalTeamConfig(); | ||
| const { displayValues, isLoading: sourcesLoading } = useSignalSourceToggles(); | ||
| const slackSkipped = useInboxOnboardingSessionStore((s) => s.slackSkipped); | ||
|
|
||
| const slackDone = hasSlackIntegration || slackSkipped; | ||
| const githubDone = hasGithubIntegration && repositories.length > 0; | ||
| const sourcesDone = Object.values(displayValues).some(Boolean); | ||
| const notificationsApplicable = hasSlackIntegration && !slackSkipped; | ||
| const notificationsDone = | ||
| !notificationsApplicable || | ||
| !!teamConfig?.default_slack_notification_channel; | ||
|
|
||
| const isLoading = teamConfigLoading || sourcesLoading; |
Contributor
There was a problem hiding this comment.
isLoading only covers teamConfigLoading || sourcesLoading, but useIntegrationSelectors reads from a zustand store that starts empty (integrations: []) and is populated asynchronously by useIntegrations(). Until that fetch resolves, hasSlackIntegration and hasGithubIntegration are both false, so isComplete computes as false before any integrations have loaded. Meanwhile, isLoading is already false if team-config and sources fetches finished first, meaning showOnboarding = true in InboxView and the welcome takeover flashes for fully-onboarded users on every page load. useRepositoryIntegration already exposes isLoadingRepos (= integrationsPending || reposPending) — including it covers both the integration-list and repos loading windows.
Suggested change
| const { hasGithubIntegration, repositories } = useRepositoryIntegration(); | |
| const { data: teamConfig, isLoading: teamConfigLoading } = | |
| useSignalTeamConfig(); | |
| const { displayValues, isLoading: sourcesLoading } = useSignalSourceToggles(); | |
| const slackSkipped = useInboxOnboardingSessionStore((s) => s.slackSkipped); | |
| const slackDone = hasSlackIntegration || slackSkipped; | |
| const githubDone = hasGithubIntegration && repositories.length > 0; | |
| const sourcesDone = Object.values(displayValues).some(Boolean); | |
| const notificationsApplicable = hasSlackIntegration && !slackSkipped; | |
| const notificationsDone = | |
| !notificationsApplicable || | |
| !!teamConfig?.default_slack_notification_channel; | |
| const isLoading = teamConfigLoading || sourcesLoading; | |
| const { | |
| hasGithubIntegration, | |
| repositories, | |
| isLoadingRepos, | |
| } = useRepositoryIntegration(); | |
| const { data: teamConfig, isLoading: teamConfigLoading } = | |
| useSignalTeamConfig(); | |
| const { displayValues, isLoading: sourcesLoading } = useSignalSourceToggles(); | |
| const slackSkipped = useInboxOnboardingSessionStore((s) => s.slackSkipped); | |
| const slackDone = hasSlackIntegration || slackSkipped; | |
| const githubDone = hasGithubIntegration && repositories.length > 0; | |
| const sourcesDone = Object.values(displayValues).some(Boolean); | |
| const notificationsApplicable = hasSlackIntegration && !slackSkipped; | |
| const notificationsDone = | |
| !notificationsApplicable || | |
| !!teamConfig?.default_slack_notification_channel; | |
| const isLoading = teamConfigLoading || sourcesLoading || isLoadingRepos; |
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/code/src/renderer/features/inbox/components/onboarding/useInboxOnboardingState.ts
Line: 63-77
Comment:
`isLoading` only covers `teamConfigLoading || sourcesLoading`, but `useIntegrationSelectors` reads from a zustand store that starts empty (`integrations: []`) and is populated asynchronously by `useIntegrations()`. Until that fetch resolves, `hasSlackIntegration` and `hasGithubIntegration` are both `false`, so `isComplete` computes as `false` before any integrations have loaded. Meanwhile, `isLoading` is already `false` if team-config and sources fetches finished first, meaning `showOnboarding = true` in `InboxView` and the welcome takeover flashes for fully-onboarded users on every page load. `useRepositoryIntegration` already exposes `isLoadingRepos` (= `integrationsPending || reposPending`) — including it covers both the integration-list and repos loading windows.
```suggestion
const {
hasGithubIntegration,
repositories,
isLoadingRepos,
} = useRepositoryIntegration();
const { data: teamConfig, isLoading: teamConfigLoading } =
useSignalTeamConfig();
const { displayValues, isLoading: sourcesLoading } = useSignalSourceToggles();
const slackSkipped = useInboxOnboardingSessionStore((s) => s.slackSkipped);
const slackDone = hasSlackIntegration || slackSkipped;
const githubDone = hasGithubIntegration && repositories.length > 0;
const sourcesDone = Object.values(displayValues).some(Boolean);
const notificationsApplicable = hasSlackIntegration && !slackSkipped;
const notificationsDone =
!notificationsApplicable ||
!!teamConfig?.default_slack_notification_channel;
const isLoading = teamConfigLoading || sourcesLoading || isLoadingRepos;
```
How can I resolve this? If you propose a fix, please make it concise.
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Merged
Twixes
force-pushed
the
graphite-base/2567
branch
from
6b2e984 to
ee7e31d
Compare
Twixes
force-pushed
the
inbox-onboarding
branch
2 times, most recently
from
593e8ba to
76381e4
Compare
Twixes
force-pushed
the
graphite-base/2567
branch
from
d31c1b2 to
8031116
Compare
Twixes
force-pushed
the
inbox-onboarding
branch
3 times, most recently
from
c254873 to
6066d0b
Compare
Rework the inbox onboarding into a sleeker, navigable stepper: Welcome -> Connect GitHub -> Connect Slack -> Activate agents, with an explicit cursor so the user can move backward as well as forward. - Welcome is now the first step (content extracted to InboxWelcomeContent); the pane owns Back/Continue, gated on each step being satisfied. - Activate step bundles signal sources + the default Slack channel; the primary CTA becomes "Activate agents". A session latch decouples visibility from isComplete so finishing the last step doesn't yank the pane mid-flow. - Welcome previews: extract a presentational PullRequestCardView reused by the real PullRequestCard, plus a high-fidelity FakeSlack component set (real report-notification block layout, PostHog Slack-app avatar, app-scaled text, Slack-style button hover/active, meep sound effects, Silicon Valley characters). - Fix broken Radix decimal gap tokens (gap="2.5" etc.) by switching to Tailwind gap utilities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #2547 (Inbox 2.0).
Summary
Adds the inbox onboarding flow that was pulled out of the Inbox 2.0 PR to keep the review surfaces cleanly separated.
Step 2 of 4 · Self-driving setup) and a per-step hedgehog tip below the action card.useInboxOnboardingStatederives per-step done-status from existing integration / team-config / source-toggle hooks. The GitHub gate uses the sameuseRepositoryIntegrationsignal the Agents view consumes ("Connected and active (N repos)") so the two surfaces agree. Session store carriesslackSkipped+welcomeAcknowledged.Test plan