Wait for worker query close before session reuse#751
Merged
Conversation
…se-before-session-reuse # Conflicts: # tests/e2e-mw-dev/harness.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the worker query close lifecycle so the control plane does not reuse a worker session until the worker has acknowledged that the previous Flight SQL DoGet operation released its server-side operation state.
Previously, FlightRowSet.Close cancelled the worker DoGet stream and returned after releasing the local reader. The worker could still be unwinding its DoGet goroutine and holding the session operation token, so the next same-session query could race into the worker and fail with FailedPrecondition.
This PR adds a small worker WaitSessionIdle action and has FlightRowSet.Close call it after cancelling the stream. That makes close/cancel completion explicit instead of relying on optimistic gRPC cancellation timing.
Changes
Tests