Skip to content

MathJax 4 knowl fix#2180

Closed
ascholerChemeketa wants to merge 7 commits intoPreTeXtBook:masterfrom
ascholerChemeketa:mj4-knowl-fix
Closed

MathJax 4 knowl fix#2180
ascholerChemeketa wants to merge 7 commits intoPreTeXtBook:masterfrom
ascholerChemeketa:mj4-knowl-fix

Conversation

@ascholerChemeketa
Copy link
Copy Markdown
Contributor

No description provided.

@rbeezer
Copy link
Copy Markdown
Collaborator

rbeezer commented Jun 20, 2024

Thabks, @ascholerChemeketa! This is acting correctly (will try lazy loading in a bit).

@rbeezer rbeezer mentioned this pull request Jun 20, 2024
Lazy loading makes above the fold content appear much quicker.
Breaks parsing of embedded knowls
</raw>
<string></string>
<xsl:choose>
<xsl:when test="$mathjax4-testing">
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the inclusion spot

@ascholerChemeketa ascholerChemeketa marked this pull request as draft July 16, 2024 15:35
@ascholerChemeketa
Copy link
Copy Markdown
Contributor Author

@rbeezer Working on startup options - converting to draft while I do so.

@ascholerChemeketa ascholerChemeketa changed the title Mj4 knowl fix MathJax 4 knowl fix Apr 25, 2025
rbeezer pushed a commit to rbeezer/pretext that referenced this pull request Apr 4, 2026
@rbeezer
Copy link
Copy Markdown
Collaborator

rbeezer commented Apr 4, 2026

@ascholerChemeketa - really nice work here, this was about 95% of what was needed for a switch (though the last 5% was a trial). I have captured the mathjax_startup.js file as the first commit on #2818 to reflect your contribution. Likely more to do, but looking good so far.

And I think some things may have been lost, like lazy loading? You might want to remind yourself about some things here and see what happened to them. I've goiot too many balls in the air right now... ;-)

I'm going to close this now and we can move to the full upgrade PR. Thanks!

@rbeezer rbeezer closed this Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants