Extract Training thresholds section into ThresholdsView#5
Open
PrernaWeb wants to merge 1 commit into
Open
Conversation
Moves the ~130-line thresholds block (run pace / FTP / swim CSS / threshold HR, the confirm flow, and the stale-set re-estimate nudge) out of the large SettingsView into its own view. Its body is a Section, so it renders identically whether embedded in Settings' Form or shown on its own. Pure, behaviour-preserving refactor; SettingsView now calls ThresholdsView(model:). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Jul 21, 2026
PrernaWeb
added a commit
that referenced
this pull request
Jul 21, 2026
…View, #6 demo infra) Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
PrernaWeb
added a commit
that referenced
this pull request
Jul 22, 2026
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Behaviour-preserving refactor: pull the ~130-line "Training thresholds" section out of the large
SettingsViewinto its ownThresholdsView. Itsbodyis aSection, so it renders identically whether embedded in Settings'Formor shown standalone.This is the only production (non-DEBUG) change split out of the marketing-screenshot work, so the reviewable surface is isolated. The DEBUG demo scaffolding that builds on it is in a follow-up stacked PR.
What changed
ThresholdsView.swift(new): run pace / cycling FTP / swim CSS / threshold HR steppers, the confirm flow, and the stale-set re-estimate nudge — moved verbatim.SettingsView.swift: removes the section + its helpers; now callsThresholdsView(model: model).Localizable.xcstrings: Xcode string-catalog re-sync (auto-generated, not hand-edited).Test plan
🤖 Generated with Claude Code