Repository navigation
Use PHP 8.4 for Docker and CI - #99
Merged
Merged
Conversation
jolelievre
force-pushed
the
php-82-security-fixes
branch
from
October 21, 2026 17:06
5b89568 to
0a73211
Compare
jolelievre
changed the title
cnavarro-prestashop
approved these changes
Oct 21, 2026
mattgoud
reviewed
Oct 21, 2026
mattgoud
left a comment
mattgoud
left a comment
Contributor
There was a problem hiding this comment.
Review 🟢 no blocker
Checks
.ai conventions: 🟢
| Source | Result |
|---|---|
| Contexts read | no .ai/ in this repository, judged on the general rules |
pr-hygiene.py |
🟢 clean |
composer validate --strict |
🟢 valid, lock in sync (the php-jwt URL and {} changes come from a newer Composer, same reference) |
Tested on: 0a73211, docker php:8.2-cli (8.2.35) and php:8.4-cli
Run: PHPUnit tests/ (112 tests, 300 assertions) and PHPStan, both green on 8.2 and 8.4; composer check-platform-reqs --lock passes on both. Checked that php:8.2-apache / php:8.2-alpine ship 8.2.35 and php:8.4-apache / php:8.4-alpine ship 8.4.27.
Not run: the cloud image build and deployment (no integration-deployment label).
Findings
- 🟠 Should fix: PHP 8.2 reaches end of life on Dec 31, 2026 (php.net), so this upgrade only buys two months before the image stops getting security fixes again. The code and the current lock already run on 8.4 as they are (tests and PHPStan green, platform requirements met), so 8.4 (security support until 2028) costs the same change:
php:8.4-apache/php:8.4-alpine,config.platform.php8.4, and the CI matrix.
Open questions
- Production deploys on a GitHub release only: is a
v1.3.15planned right after the merge so the patched image actually ships?
jolelievre
force-pushed
the
php-82-security-fixes
branch
from
October 21, 2026 17:29
0a73211 to
ed36edc
Compare
mattgoud
approved these changes
Oct 21, 2026
ps-jarvis
added
the
Waiting for QA
jolelievre
force-pushed
the
php-82-security-fixes
branch
from
October 21, 2026 17:32
ed36edc to
8ab3cf5
Compare
M0rgan01
approved these changes
Oct 21, 2026
jolelievre
removed
the
Waiting for QA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
php.ini. Dependencies are unchanged, the lock file only gets its hash/platform updated.php -vin the container must show PHP 8.4.