Fix footer size on terms pages#426
Conversation
|
|
There was a problem hiding this comment.
This seems to be an issue specifically on pages which use the blogpost styles (terms included) - the wrapper is set to 100% here
I think this PR should make use of the blogpost CSS file and set the footer width - I don't think the templating for the page type is needed
(also please merge our dev into your branch, I've updated it so master commits won't show 😄)
|
I removed the classes I created, changed the |
|
Hi! It still looks like you're making unnecessary changes (see your two commits in isolation here): |
|
@limesdotpink oh yeah my bad I'm going to fix this |
binaryoverload
left a comment
binaryoverload
left a comment
There was a problem hiding this comment.
Thanks for cleaning up the PR! Just a thought on the change
| @media screen and (max-width: 600px) { | ||
| .wrapper { | ||
| width: 100%; | ||
| width: 90%; |
There was a problem hiding this comment.
The reason this was 100% was so the text was as wide as possible on mobile. I think the best solution right now is to add an !important to the footer width on line 233 since it's being overridden by 100% on the footer partial
5 participants
Resolves #381
Changes:
add a class to the body to see on which type of page we are on
Adding this feature helps to modify pages by knowing on which type of page we are on.
With this feature, I have fixed the problem with the footer in the terms pages.