Menu-bar width & Responsiveness fixed#103
Open
faizalmsdev wants to merge 2 commits intoPritamSarbajna:mainfrom
Open
Menu-bar width & Responsiveness fixed#103faizalmsdev wants to merge 2 commits intoPritamSarbajna:mainfrom
faizalmsdev wants to merge 2 commits intoPritamSarbajna:mainfrom
Conversation
✅ Deploy Preview for simple-tourism-organization ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
PritamSarbajna
requested changes
Jun 17, 2023
Owner
PritamSarbajna
left a comment
PritamSarbajna
left a comment
There was a problem hiding this comment.
The PR needs following changes :
- The menu bar should cover the whole area or 90% from the middle.
- When for closing I'm pressing the menu it is shrinking and then closing. Please fix it.
- Menu Bar design is good.
Author
|
Noted , you mean when i click the menu bar its need to open onfull width of home screen? |
Owner
Yeah if not full then atleast 90%. |
codeCraft-Ritik
left a comment
codeCraft-Ritik
left a comment
There was a problem hiding this comment.
Nice approach — the logic flows well and is readable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per your advice i just fixed the width of the menu-bar and its become more responsiveness.