Skip to content

fix(navigation): migrate standard HTML links to Next.js Link components for SPA routing #1787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ArshVermaGit wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(navigation): migrate standard HTML links to Next.js Link components for SPA routing #1787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/app/compare/[users]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { Metadata } from "next";
import Link from "next/link";
import { Scale, Trophy } from "lucide-react";
import Image from "next/image";
import { normalizeGitHubUsername } from "@/lib/validate-github-username";
Expand Down Expand Up @@ -110,12 +111,12 @@ export default async function PublicProfileComparePage({
Shareable comparison built only from publicly visible DevTrack stats.
</p>
</div>
<a
<Link
href={`/u/${encodeURIComponent(rightProfile.username)}`}
className="secondary-button inline-flex rounded-lg px-4 py-2 text-sm font-medium"
>
View profile
</a>
</Link>
</div>

<div className="grid grid-cols-1 gap-4 md:grid-cols-[1fr_auto_1fr] md:items-stretch">
Expand Down Expand Up @@ -201,9 +202,9 @@ function CompareUnavailable({
<div className="surface-card max-w-md rounded-2xl p-8 text-center">
<h1 className="mb-2 text-3xl font-bold">{title}</h1>
<p className="mb-6 text-sm text-[var(--muted-foreground)]">{message}</p>
<a href="/" className="primary-button inline-block rounded-lg px-6 py-2">
<Link href="/" className="primary-button inline-block rounded-lg px-6 py-2">
Back to Home
</a>
</Link>
</div>
</div>
);
Expand Down Expand Up @@ -235,12 +236,12 @@ function ProfileHeader({
className="h-14 w-14 rounded-full border border-[var(--border)]"
/>
<div className="min-w-0">
<a
<Link
href={`/u/${encodeURIComponent(profile.username)}`}
className="truncate text-xl font-bold text-[var(--card-foreground)] hover:text-[var(--accent)]"
>
@{profile.username}
</a>
</Link>
<p className="text-sm text-[var(--muted-foreground)]">
{profile.streak.current} day streak - {profile.contributions.total} commits
</p>
Expand Down
5 changes: 3 additions & 2 deletions src/app/dashboard/settings/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1196,12 +1196,13 @@ function SettingsPageContent() {
</p>
</div>

<a
<Link
href="/api/auth/link-github"
prefetch={false}
className="inline-flex items-center justify-center rounded-lg bg-[var(--accent)] px-4 py-2 text-sm font-medium text-[var(--accent-foreground)] hover:opacity-90 transition-opacity"
>
Add GitHub Account
</a>
</Link>
</div>

{removeError && (
Expand Down
17 changes: 9 additions & 8 deletions src/app/u/[username]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
export const dynamic = "force-dynamic";

import { Metadata } from "next";
import Link from "next/link";
import { redirect } from "next/navigation";
import { getServerSession } from "next-auth";
import BadgeSection from "@/components/BadgeSection";
Expand Down Expand Up @@ -98,20 +99,20 @@ export default async function PublicProfilePage({
</p>
<p className="text-sm text-[var(--muted-foreground)] mb-6">
If this is your profile, go to{" "}
<a
<Link
href="/dashboard/settings"
className="text-[var(--accent)] underline hover:opacity-80"
>
Settings
</a>{" "}
</Link>{" "}
and enable <strong>Public Profile</strong>.
</p>
<a
<Link
href="/"
className="primary-button inline-block rounded-lg px-6 py-2"
>
Back to Home
</a>
</Link>
</div>
</div>
);
Expand Down Expand Up @@ -149,20 +150,20 @@ export default async function PublicProfilePage({
GitHub activity and coding stats
</p>
{compareHref && (
<a
<Link
href={compareHref}
className="primary-button mt-4 inline-flex rounded-lg px-4 py-2 text-sm font-semibold"
>
Compare with me
</a>
</Link>
)}
{!loggedInUsername && (
<a
<Link
href={signInToCompareHref}
className="secondary-button mt-4 inline-flex rounded-lg px-4 py-2 text-sm font-semibold"
>
Log in to compare
</a>
</Link>
)}
</div>
{/* Download stats card button — client component */}
Expand Down
9 changes: 5 additions & 4 deletions src/components/landing/LandingPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import { useEffect, useRef, useState } from 'react';
import Image from "next/image";
import Link from 'next/link';

/* ═══════════════════════════════════════════════════════════
PUBLIC TYPES
Expand Down Expand Up @@ -422,7 +423,7 @@ function HeroSection() {

{/* CTAs */}
<div style={{ display: 'flex', gap: 16, flexWrap: 'wrap' }}>
<a href="/api/auth/signin/github?callbackUrl=/dashboard" className="lnd-cta-primary" style={{
<Link href="/api/auth/signin/github?callbackUrl=/dashboard" prefetch={false} className="lnd-cta-primary" style={{
boxShadow: '0 8px 24px rgba(129,140,248,0.3)',
transition: 'transform 0.3s, box-shadow 0.3s',
transform: 'translateY(0)',
Expand All @@ -439,7 +440,7 @@ function HeroSection() {
<path d="M8 0C3.58 0 0 3.58 0 8c0 3.54 2.29 6.53 5.47 7.59.4.07.55-.17.55-.38 0-.19-.01-.82-.01-1.49-2.01.37-2.53-.49-2.69-.94-.09-.23-.48-.94-.82-1.13-.28-.15-.68-.52-.01-.53.63-.01 1.08.58 1.23.82.72 1.21 1.87.87 2.33.66.07-.52.28-.87.51-1.07-1.78-.2-3.64-.89-3.64-3.95 0-.87.31-1.59.82-2.15-.08-.2-.36-1.02.08-2.12 0 0 .67-.21 2.2.82.64-.18 1.32-.27 2-.27s1.36.09 2 .27c1.53-1.04 2.2-.82 2.2-.82.44 1.1.16 1.92.08 2.12.51.56.82 1.27.82 2.15 0 3.07-1.87 3.75-3.65 3.95.29.25.54.73.54 1.48 0 1.07-.01 1.93-.01 2.2 0 .21.15.46.55.38A8.013 8.013 0 0016 8c0-4.42-3.58-8-8-8z" />
</svg>
Sign in with GitHub
</a>
</Link>
<a
href="https://github.com/Priyanshu-byte-coder/devtrack"
target="_blank"
Expand Down Expand Up @@ -719,9 +720,9 @@ function SetupSection() {
</div>

<div style={{ display: 'flex', gap: 12, flexWrap: 'wrap', justifyContent: 'center' }}>
<a href="/api/auth/signin/github?callbackUrl=/dashboard" className="lnd-cta-primary">
<Link href="/api/auth/signin/github?callbackUrl=/dashboard" prefetch={false} className="lnd-cta-primary">
Sign in with GitHub
</a>
</Link>
<a
href="https://github.com/Priyanshu-byte-coder/devtrack"
target="_blank"
Expand Down
Loading