fix(api): cleanly handle abort signals and controller state in SSE stream API#1795
Open
ArshVermaGit wants to merge 1 commit into
Open
fix(api): cleanly handle abort signals and controller state in SSE stream API#1795ArshVermaGit wants to merge 1 commit into
ArshVermaGit wants to merge 1 commit into
Conversation
|
@ArshVermaGit is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
ArshVermaGit
commented
May 31, 2026
Contributor
Author
ArshVermaGit
left a comment
There was a problem hiding this comment.
Hi @Priyanshu-byte-coder ! Issue #1794 has been resolved. Please review the PR and merge it under GSSoC. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses flakiness and memory leak issues in the Server-Sent Events (SSE) streaming API (
/api/stream), as well as fixing the associated test suite which was failing completely.Previously, if a client disconnected while the backend was waiting on an asynchronous database poll, the server would subsequently attempt to call
controller.enqueue()on an already closed stream. This resulted in noisyTypeError: Invalid state: Controller is already closedexceptions and potential hanging promises.Additionally, the
test/sse-stream-route.test.tssuite was completely failing due to a cross-environment Type mismatch whereNextRequestrejected the Node-nativeAbortSignalconstructed by Vitest.Resolved Issue
Resolves #1794
Changes Made
isClosedflag to the SSE polling logic. The interval now immediately halts on abort, and any pending async database responses are safely discarded without attempting to enqueue into a dead stream.NextRequestconstructor validations by injecting theAbortSignalviaObject.definePropertypost-instantiation.Impact
Testing
npm run test test/sse-stream-route.test.ts).