fix: close sse stream on abort#1812
Open
Divv1524 wants to merge 1 commit into
Open
Conversation
|
@Divv1524 is attempting to deploy a commit to the PRIYANSHU DOSHI's projects Team on Vercel. A member of the Team first needs to authorize it. |
GSSoC Label Checklist 🏷️@Priyanshu-byte-coder — please apply the appropriate labels before merging: Difficulty (pick one):
Quality (optional):
Validation (required to score):
|
There was a problem hiding this comment.
Thanks for your first PR on DevTrack! 🎉
A maintainer will review it within 48 hours. While you wait:
- Make sure CI is passing (type-check + lint)
- Double-check the PR description is filled out and the issue is linked
- Feel free to ask questions in Discussions if you need help
If you find DevTrack useful, a ⭐ star on the repo is always appreciated — it helps the project grow and attract more contributors!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed the SSE stream lifecycle in
/api/streamso server-side resources are cleaned up reliably when clients disconnect, streams are canceled, or connections become stale.Closes #1608
Type of Change
Changes Made
ReadableStreamcontroller on client abortcontroller.enqueue()handling to prevent writes to closed streamsHow to Test
Steps for the reviewer to verify this works:
npm run lintnpm run type-checknpm run buildvitest run test/sse-stream-route.test.tsScreenshots (if UI change)
N/A
Checklist
npm run lintpasses locallynpm run type-check)Accessibility Checklist
Additional Notes
Full
npm testwas also run. The focused SSE test suite passed, but the full suite currently has unrelated pre-existing failures outside this change.