Fix plugin cloud sync: wire CloudSyncInvalidationBus to PluginManager#402
Merged
Merged
Conversation
Bug: PluginManager.triggerRemoteSync() always returned early due to
dead code (if (true) { return }) from old Supabase auth guard.
Plugin adds/removes/toggles were saved locally but never pushed to cloud.
Fix:
- Add CloudSyncScope.PLUGINS to the invalidation scope enum
- Add PLUGINS debounce (1000ms) to CloudSyncCoordinator
- Inject CloudSyncInvalidationBus into sideload PluginManager
- Replace dead triggerRemoteSync() with invalidationBus.markDirty()
- Wire markDirty() to: addRepository, removeRepository, toggleScraper,
toggleAllScrapersForRepo, setPluginsEnabled, flushPendingSync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
PluginManager.triggerRemoteSync()always returned early due to dead code left from the old Supabase auth system:As a result, adding/removing plugin repositories was saved locally only and never triggered a cloud push.
Fix
3 files changed:
1.
CloudSyncInvalidationBus.ktAdd
PLUGINSto theCloudSyncScopeenum so the coordinator knows how to debounce plugin changes.2.
CloudSyncCoordinator.ktAdd 1000ms debounce for
PLUGINSscope (between IPTV's 750ms and LOCAL_HISTORY's 2000ms).3.
PluginManager.kt(sideload)CloudSyncInvalidationBustriggerRemoteSync()implementation withinvalidationBus.markDirty(CloudSyncScope.PLUGINS, ...)markDirty()to:addRepository,removeRepository,toggleScraper,toggleAllScrapersForRepo,setPluginsEnabled,flushPendingSyncResult
After this fix, any plugin change (add repo, remove repo, enable/disable scraper) will:
CloudSyncCoordinatorvia the invalidation bus (1s debounce)pluginRepositories+pluginScrapers) to cloud