Update compose text field assertion steps, add new steps to assert disabled status#46
Merged
Merged
Conversation
automation-amber
approved these changes
Jun 24, 2026
a083409
approved these changes
Jun 25, 2026
a083409
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compose text field assertion steps no longer look for
hasSetTextAction()which is only there when the node is enabled. Now they look forSemanticsMatcher.keyIsDefined(SemanticsProperties.EditableText)which is on both enabled and not enabled text fields, but not on other nodes like text or buttons. Compose text field action steps remain the same since there aren't a lot of actions one can do on a disabled node.Added new text field assertion steps that specifically look for
isNotEnabled(). Will not be addingisEnabled()checks to existing steps.